drm-syncobj: Fix check for acquire/release point order

This check was backwards, but that wasn't apparent since not all implementations use the same timeline for both.
Smithay · Oct 2, 2024 · 59ed761 · 59ed761
1 parent b6bb20e
commit 59ed761
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/wayland/drm_syncobj/mod.rs b/src/wayland/drm_syncobj/mod.rs
@@ -203,11 +203,11 @@ fn commit_hook<D: DrmSyncobjHandler>(_data: &mut D, _dh: &DisplayHandle, surface
                 } else if let (Some(acquire), Some(release)) =
                     (pending.acquire_point.as_ref(), pending.release_point.as_ref())
                 {
-                    if acquire.timeline == release.timeline && acquire.point <= release.point {
+                    if acquire.timeline == release.timeline && release.point <= acquire.point {
                         syncobj_surface.post_error(
                             wp_linux_drm_syncobj_surface_v1::Error::ConflictingPoints as u32,
                             format!(
-                                "release point '{}' is not greater than acquire point '{}'",
+                                "release point {} is not greater than acquire point {}",
                                 release.point, acquire.point
                             ),
                         );