Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deadlock in AtomicDrmDevice #1544

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

m4rch3n1ng
Copy link
Contributor

88cdf9b introduced a deadlock when creating AtomicDrmDevice, as

let mut mapping = dev.prop_mapping.write().unwrap();
causes a deadlock in
let prop_mapping = self.prop_mapping.read().unwrap();
, since the mapping is dropped too late. this changes it to be dropped earlier.

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Drakulix Drakulix merged commit 0cd0895 into Smithay:master Sep 21, 2024
12 of 13 checks passed
@m4rch3n1ng m4rch3n1ng deleted the deadlock-v2 branch September 21, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants