feat: add a layershellexample #619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decodetalkers
force-pushed
the
layershellexample
branch
2 times, most recently
from
38472df
to
97b431c
Compare
WhyNotHugo
reviewed
Jul 3, 2023
Comment on lines
106
to
117
| impl Dispatch<wl_compositor::WlCompositor, ()> for State { | ||
| fn event( | ||
| _: &mut Self, | ||
| _: &wl_compositor::WlCompositor, | ||
| _: wl_compositor::Event, | ||
| _: &(), | ||
| _: &Connection, | ||
| _: &QueueHandle<Self>, | ||
| ) { | ||
| // wl_compositor has no event | ||
| } | ||
| } |
There was a problem hiding this comment.
Want to use delegate_noop! here instead?
Suggested change
| impl Dispatch<wl_compositor::WlCompositor, ()> for State { | |
| fn event( | |
| _: &mut Self, | |
| _: &wl_compositor::WlCompositor, | |
| _: wl_compositor::Event, | |
| _: &(), | |
| _: &Connection, | |
| _: &QueueHandle<Self>, | |
| ) { | |
| // wl_compositor has no event | |
| } | |
| } | |
| delegate_noop!(State: wl_compositor::WlCompositor); |
Since this is an example, let's use the approach that's simplest for other to follow :)
There was a problem hiding this comment.
but I want it be the same as xdg-shell, emm, to show they are similar
There was a problem hiding this comment.
Might be best to update that example to use delegate_noop! too.
|
I just wanted to say, thank you very much for this example! It has really helped me out and guided me! Why exactly has it not yet been merged?? This is gold! |
Decodetalkers
force-pushed
the
layershellexample
branch
from
97b431c
to
ace9c7a
Compare
Decodetalkers
force-pushed
the
layershellexample
branch
from
ace9c7a
to
1fea0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that layershell is very similar with xdg, so I want to add one example of layershell with origin wayland-rs..because the are so similar