Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic CRUD operations for REST API #18

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Implement basic CRUD operations for REST API #18

merged 1 commit into from
Oct 1, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Aug 30, 2024

This Pull Request introduces basic CRUD operations for the following application entities:

  • Policy
  • External identity
  • Policy attachment to external identity

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner August 30, 2024 14:15
Copy link

Coverage after merging crud into main will be

4.90%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   main.rs0%100%0%0%22, 40–67
src/http
   conversions.rs95.65%100%100%94.74%26
   urls.rs0%100%0%0%100–110, 112–119, 12, 120–125, 127–129, 13, 130–139, 14, 141–149, 15, 150–153, 16–29, 31, 33, 35–48, 50–60, 62–72, 74–86, 88–98
src/models/external
   identity.rs0%100%0%0%16–21, 25–27, 38–40, 42–46, 49, 56–58, 60–64, 66–70
   identity_provider.rs0%100%0%0%10–11, 16–18, 9
   token.rs100%100%100%100%
src/models/internal/v1
   token.rs0%100%0%0%24–33, 39, 52–55, 58–79
src/services
   configuration_manager.rs0%100%0%0%25–48, 50–52
   external_identity_validator.rs0%100%0%0%42–56, 59–67, 76–86
   identity_validator_provider.rs0%100%0%0%13–15, 46–52, 61–66, 70–73
   token_service.rs0%100%0%0%40–77, 81–93
src/services/repositories
   in_memory.rs0%100%0%0%100–103, 14–20, 26–30, 32–36, 43–49, 51–55, 57–61, 70–76, 82–97, 99

@s-vitaliy s-vitaliy merged commit 6065e13 into main Oct 1, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the crud branch October 1, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants