Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue#29, Issue#30, Issue#33, Issue#35. #64

Closed
wants to merge 5 commits into from
Closed

Fixes Issue#29, Issue#30, Issue#33, Issue#35. #64

wants to merge 5 commits into from

Conversation

rajneesh069
Copy link
Contributor

@rajneesh069 rajneesh069 commented Jan 6, 2024

Fixes Issues: #29 , #30, #33, #35 Moved the scripts tag into the head tag and added the defer attribute to them. Moved the app.js file into the scripts folder. Moved the styles inside styles.css and added inline styling in the body tag inside index.html. Then added 2 new files in the scripts folder and finally applied the save previous mute preferences feature.

…them. Moved the app.js file into the scripts folder. Moved the styles inside styles.css and added inline styling in the body tag inside index.html
@rajneesh069 rajneesh069 changed the title Moved the scripts tag into the head tag and added defer attribute to them. Issue #29, Issue #30, Issue #33, Issue #35 solved. Jan 6, 2024
@rajneesh069
Copy link
Contributor Author

@nisha-laur These are all the changes I proposed to make in the repository by opening the issues in the issues section and I've implemented all of them. Please look into it. @Nitya-Pasrija

@rajneesh069 rajneesh069 changed the title Issue #29, Issue #30, Issue #33, Issue #35 solved. Fixes Issue#29, Issue#30, Issue#33, Issue#35. Jan 6, 2024
Copy link
Contributor

@Nitya-Pasrija Nitya-Pasrija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create 4 separate PRs to resolve them, do look into branching to help you with this :)

@rajneesh069
Copy link
Contributor Author

rajneesh069 commented Jan 6, 2024

Please create 4 separate PRs to resolve them, do look into branching to help you with this:
Hey, I get what you're saying but the thing is that the changes are progressive and need to be made one after the other. One of the commits changes the folder structure itself by introducing the scripts. I opened two PRs before regarding that only but each time some other PR got merged and there was a merge conflict and I was unable to resolve it as the option to resolve them was greyed out and when I pulled the changes using Git no conflict was shown, that's why I decided to make commits one after the other in the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants