Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra pint rule #1256

Closed
wants to merge 1 commit into from
Closed

Add extra pint rule #1256

wants to merge 1 commit into from

Conversation

lucasmichot
Copy link
Member

Add ab extra pint rule

Copy link
Member

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reasoning for this change?

@lucasmichot
Copy link
Member Author

what's the reasoning for this change?

Just ensure that arrows are aligned with the minimal amount of spaces necessary. eg.:

--- a/src/Pipedrive/Provider.php
+++ b/src/Pipedrive/Provider.php
@@ -51,9 +51,9 @@ class Provider extends AbstractProvider
     protected function mapUserToObject(array $user)
     {
         return (new User)->setRaw($user)->map([
-            'id'       => $user['data']['id'],
-            'name'     => $user['data']['name'],
-            'email'    => $user['data']['email'],
+            'id'    => $user['data']['id'],
+            'name'  => $user['data']['name'],
+            'email' => $user['data']['email'],
         ]);
     }
 }

@atymic
Copy link
Member

atymic commented Aug 30, 2024

IMO It's not worth polluting the changes history of all the files for this change

@lucasmichot lucasmichot closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants