[G4] Instrument implementations #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fb lyre impl
…HEIGVD-RES-2017-Labo-00 into fb-all-instruments
Fb implementation of Maracas
Fb melodeon impl
…HEIGVD-RES-2017-Labo-00 into fb-marimba-implementation
Marimba instrument implemented. Fixes SoftEng-HEIGVD#363
…ng-HEIGVD-RES-2017-Labo-00 into fb-all-instruments
Fb mandolin impl
Fb mellophone impl
|
Nice :-). Just a couple of things before I accept the PR:
Up to you if you want to ask your team mates to do the change, or if you handle the integration yourself. Thanks! |
|
You probably have not added/commited everything: I only see the header removed from Mandolin.java. |
|
Sorry to be picky, but the last 2 files still have the headers... |
|
Did not see those, sorry. Next commit to come should be fine (at last). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all issues for group G4. Fixes #337 #330 #349 #310 #396 #363 #348 #347