[TOREVIEW] Pozniakoff_Vallon #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, lorsque le transformer sera en place
…-HEIGVD-Teaching-HEIGVD-RES-2021-Labo-Java-IO into feat/filters
…h to merge it all
Fb transformer
Fb visitor
Revert "Fb visitor"
fix visitor, now pass the tests
…-HEIGVD-Teaching-HEIGVD-RES-2021-Labo-Java-IO into feat/FileNumberingFilterWriter
Feat/file numbering filter writer
Feat/utils
…terWriter Revert "Feat/file numbering filter writer"
Revert "Feat/utils"
Revert "fix visitor, now pass the tests"
fixing git
…oftEng-HEIGVD-Teaching-HEIGVD-RES-2021-Labo-Java-IO into feat/Utils
Feat/utils
… pour sort le dfs
Added the commentaries and did final check
woopsy daisy zappé des trucs
aidanBurton
reviewed
Mar 21, 2021
| @@ -133,7 +132,18 @@ void clearOutputDirectory() throws IOException { | |||
| * @throws IOException | |||
| */ | |||
| void storeQuote(Quote quote, String filename) throws IOException { | |||
| throw new UnsupportedOperationException("The student has not implemented this method yet."); | |||
| String tmp = new String(); | |||
There was a problem hiding this comment.
I detect that this code is problematic. According to the Performance (PERFORMANCE), Dm: Method invokes inefficient new String() constructor (DM_STRING_VOID_CTOR).
Creating a new java.lang.String object using the no-argument constructor wastes memory because the object so created will be functionally indistinguishable from the empty string constant "". Java guarantees that identical string constants will be represented by the same String object. Therefore, you should just use the empty string constant directly.
There was a problem hiding this comment.
Fixed it, the string is now initialized with empty string
|
Please review again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.