Preventing nested zipping of the portable Windows build

[discip]

As stated in the header.

Makes extracting the actually required files a bit easier. 😊

[Noisyfox]

Is this still needed? Recent releases and nightly builds do not have nested zip files I believe.

[discip]

Will check later,
not near my machine right now.

[discip]

@Noisyfox
Good morning Sir,
as promised, I checked and found that this is still required as even the latest portable Windows build (https://github.com/SoftFever/OrcaSlicer/actions/runs/12734430763) is a nested zip file.

[discip]

@Noisyfox
Just found the following comment regarding this topic, stating:

Ok. I grabbed the portable thinking it would keep me from screwing up my working installation.
Its a zip of a folder whose only content is a zip? That's odd.

Originally posted by @tlhintoq in #8038 (comment)

[Noisyfox]

@Noisyfox Just found the following comment regarding this topic, stating:

Ok. I grabbed the portable thinking it would keep me from screwing up my working installation.
Its a zip of a folder whose only content is a zip? That's odd.

Originally posted by @tlhintoq in #8038 (comment)

That's PR build, which is uploaded by github's own action actions/upload-artifact, I was referring to the nightly release which is uploaded by WebFreak001/deploy-nightly

[discip]

That's PR build, which is uploaded by github's own action actions/upload-artifact, I was referring to the nightly release which is uploaded by WebFreak001/deploy-nightly

Ah!
That one works as expected.

But I think most tinkerers rely on the dev builds as you want to test a specific PR rather than the nightly build and if you don't want to compromise your current installation you need to go with the portabel version.
So it would be very nice if the portable version wasn't zipped twice. 😊

I hope that makes sense.

The changes I made are not state of the art, but that's all I was able to achieve.
Maybe you have a cleaner solution. I would highly appreciate it and even prefer it to mine.

[Noisyfox]

I guess you have to uncomment these part otherwise the zip file doesn't exist.

[discip]

That's the thing.
If this is uncommented the files get zipped the 1st time and than it gets zipped the second time with this:

      - name: Upload artifacts Win zip
        if: inputs.os == 'windows-latest'
        uses: actions/upload-artifact@v4
        with:
          name: OrcaSlicer_Windows_${{ env.ver }}_portable
          path: ${{ github.workspace }}/build/OrcaSlicer

[Noisyfox]

As long as Path points to the dir not the zip it should be fine.

[Noisyfox]

LGTM, thanks~ I'll merge this once the PR build completed.