Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover an app with unit tests (part #1) #3

Merged
merged 7 commits into from
Aug 16, 2022
Merged

Conversation

valentyn-arkho
Copy link
Collaborator

@valentyn-arkho valentyn-arkho commented Jun 19, 2021

Description

Currently an application doesn't have unit tests. It's very important to cover all app with unit tests on 100%.

Need to:

  • add jest configuration - ✅;
  • add pre-push hook to verify, that tests coverage won't decrease after adding new changes - ✅;
  • add pre-commit hook to verify, if there are no problems in code (eslint and prettier) - ✅;
  • cover whole app with unit tests (min 40% of coverage ⚠️).

Current issue link - #2;

How to test

  1. Run npm run test command;
  2. Verify, that all app was covered by unit tests.

Screenshots

image

PR Author Checklist

The following are required to be performed and subsequently checked off by the PR Author for all PRs, no exception. Note that, PR Reviewers rely on the "X of Y" display for each pull request in the Pull request tab of this repository, and thus may ignore your PR until your PR shows "3 of 3" in the Pull requests tab for this repo.

  • Sections of this PR template not filled in or are not applicable have been removed
  • Existing tests are passing (npm test)
  • package-lock.json is not part of the changed files if there are no changes to package.json

@valentyn-arkho valentyn-arkho force-pushed the ADDING_UNIT_TESTS branch 3 times, most recently from 5265e44 to d04f11d Compare June 19, 2021 14:18
@valentyn-arkho valentyn-arkho changed the title Cover an app with unit tests Cover an app with unit tests (part #1) Aug 16, 2022
@valentyn-arkho valentyn-arkho added Status: In Progress Special for issues and removed HOLD labels Aug 16, 2022
@valentyn-arkho valentyn-arkho merged commit 8f60ed1 into master Aug 16, 2022
@valentyn-arkho valentyn-arkho deleted the ADDING_UNIT_TESTS branch August 16, 2022 03:07
@valentyn-arkho valentyn-arkho added MERGE READY Status: Done Special for issues and removed Status: In Progress Special for issues Status: Done Special for issues labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant