Modernize Repo + remove hardcoded state #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/allianceauth-corp-tools-pinger into hardcodestate
soratidus999
changed the title
soratidus999
merged commit 7d81e91
into
Solar-Helix-Independent-Transport:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a setting for valid state names, instead of hardcoded to member. This can probably be a M2M in pingerconfig, but i was keeping it simple
expands install readme a bit
brings pre-commit into line with corp-tools core so there was some formatting changes, will likely modernize the repo at a later point with pyproject.toml
CT_PINGER_VALID_STATES is the important change