Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude port from chatContainerStr #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bourgeoa
Copy link
Contributor

@bourgeoa bourgeoa commented Dec 8, 2020

The port has no meaning in this context and will allow compatibility with Windows where colon are forbidden in file/folder names.
It has not impact on solidcommunity.net nor inrupt.net, or any of podProvider that do not use a specific port.
see issue SolidOS/solid-panes#262

The port has no meaning in this context and will allow compatibility with Windows where colon are forbidden in file/folder names.
It has not impact on `solidcommunity.net` nor `inrupt.net`, or any of podProvider that do not use a specific port. 
see issue SolidOS/solid-panes#262
@TallTed
Copy link
Contributor

TallTed commented Dec 8, 2020

This does mean that server admins should now be cautioned that IF they run multiple Solid server instances on a single host, they will need to set each Solid server to use a different filesystem directory as their root to avoid possible folder-tree collisions. (This is probably a SHOULD anyway, but with this change it becomes a MUST.)

@bourgeoa
Copy link
Contributor Author

bourgeoa commented Dec 8, 2020

This already is the case when using NSS, Pod folder is the hostname and do not include the port.

I have not seen anything in specification relative to filesystem.

The above case do not relate to the same thing. It is the name of a folder inside a pod folder. It could be named me and the URI would have been https://<pod>/IndividualChats/me

If a unique name was wanted it could be a webId

@TallTed
Copy link
Contributor

TallTed commented Dec 9, 2020

OK, I misinterpreted your comment about "any of podProvider that do not use a specific port" to mean that this would impact any podProvider that did use a specific port.

@highlevellogic
Copy link

highlevellogic commented Dec 13, 2020

Individual pod directories are currently named without a port. My account directory on https://solid.hll.nu:7443 is named rogerfgay.solid.hll.nu

@highlevellogic
Copy link

highlevellogic commented Dec 16, 2020

Perhaps we can just remove the ':' to avoid collisions.
Any need to encode the rest?

Base automatically changed from master to main February 24, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants