Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] incorporate folder-table module #229

Closed
wants to merge 1 commit into from
Closed

[WiP] incorporate folder-table module #229

wants to merge 1 commit into from

Conversation

timbl
Copy link
Contributor

@timbl timbl commented Mar 27, 2020

The folder-table adds an alternative simpler folder viewer

@timbl
Copy link
Contributor Author

timbl commented Mar 27, 2020

Do not merge this until folder-table is working

@megoth megoth changed the title incorporate folder-table module [WiP] incorporate folder-table module Mar 27, 2020
@megoth
Copy link
Contributor

megoth commented Mar 27, 2020

I've taken the liberty of prefixing this with [WiP], to indicate you don't want to merge it until it's removed.

@angelo-v
Copy link
Contributor

Do not merge this until folder-table is working

Is it working in the meanwhile or what is the status?

@michielbdejong
Copy link
Contributor

How is this related to https://github.com/solid/folder-pane ?

@angelo-v angelo-v self-assigned this Dec 16, 2020
@angelo-v
Copy link
Contributor

You tell me, @michielbdejong - you are the author? https://github.com/solid/folder-table/graphs/contributors

I ran into this issue when trying to integrate it solid-contrib/folder-table#15

Therefore I am closing this PR. An up to date one can be provided if everything is supposed to work

@angelo-v angelo-v closed this Dec 16, 2020
@michielbdejong
Copy link
Contributor

Fascinating, it does look like I'm the author, but I don't remember it that way.. Maybe I moved things around and that makes it look like I contributed a lot.

@angelo-v
Copy link
Contributor

Weird... I cloned the repo to check the history locally and there are several of @timbl 's commits before yours. After I did that I can see those on github now as well. Those haven't been visible before 👀

@timea-solid timea-solid deleted the folder-table branch February 28, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants