Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long chat desktop notifications #181

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Conversation

michielbdejong
Copy link
Contributor

No description provided.

@michielbdejong
Copy link
Contributor Author

You can try it out on https://chat.inrupt.app/

@Vinnl
Copy link
Contributor

Vinnl commented Jan 6, 2020

When I click the login button at the bottom:

image

I also don't see how I can add messages?

@michielbdejong
Copy link
Contributor Author

@Vinnl that's due to SolidOS/chat-pane#28, you should use the small login button at the top

@Vinnl
Copy link
Contributor

Vinnl commented Jan 6, 2020

Cool, I figured that :)

I still couldn't see how to add messages, and after refreshing I get just this:

image

@brownhoward
Copy link

After a few page refreshes, I see the standard component for entering chat messages.
Screen Shot 2020-01-06 at 8 12 51 AM

What is not obvious is how to create a new chat.

@michielbdejong
Copy link
Contributor Author

It seems to work in Chrome but not in FF?

@michielbdejong
Copy link
Contributor Author

Ah correction, it's not because of FF vs Chrome, it's because of SolidOS/chat-pane#31

Copy link
Contributor

@megoth megoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've loved for this to be a bit more planned out in terms of what our notification strategy in the data browser is in general, but I'll accept this as-is (but please reconsider the use of alert...).

src/chat/infinite.js Outdated Show resolved Hide resolved
@megoth megoth added this to the Data Browser Release 5 milestone Jan 6, 2020
@michielbdejong michielbdejong merged commit 77b392f into master Jan 8, 2020
@michielbdejong michielbdejong deleted the long-chat-desktop-notifs branch January 8, 2020 09:44
@michielbdejong michielbdejong restored the long-chat-desktop-notifs branch January 8, 2020 10:57
@michielbdejong
Copy link
Contributor Author

Restoring branch to make https://travis-ci.org/solid/solid-ui/jobs/634157446 pass

@megoth megoth deleted the long-chat-desktop-notifs branch January 9, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants