Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECHOES-531 Implement FormFieldLabel #243

Merged
merged 2 commits into from
Jan 8, 2025
Merged

ECHOES-531 Implement FormFieldLabel #243

merged 2 commits into from
Jan 8, 2025

Conversation

gregaubert
Copy link
Member

@gregaubert gregaubert commented Jan 8, 2025 •
edited by jira bot
Loading

ECHOES-531

Build doesn't pass because of the broken code from the target branch

@gregaubert gregaubert requested a review from daniel-nagy January 8, 2025 16:42
daniel-nagy
daniel-nagy approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@daniel-nagy daniel-nagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/components/form/FormFieldLabel.tsx Show resolved Hide resolved
src/components/form/index.ts Outdated Show resolved Hide resolved
src/components/form/FormFieldLabel.tsx Outdated Show resolved Hide resolved
@gregaubert gregaubert merged commit a4632f6 into form-components Jan 8, 2025
0 of 2 checks passed
@gregaubert gregaubert deleted the greg/label branch January 8, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-nagy daniel-nagy daniel-nagy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregaubert @daniel-nagy