Revert "unlearn constraints"

This reverts commit cba9ba8.
SonarSource · Jul 3, 2024 · 718a236 · 718a236
1 parent 1cf8a40
commit 718a236
Show file tree

Hide file tree

Showing 2 changed files with 2,147 additions and 19 deletions.
diff --git a/...rc/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/CollectionTracker.cs b/...rc/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/CollectionTracker.cs
@@ -72,13 +72,6 @@ internal static class CollectionTracker
         nameof(Stack<int>.Pop)
     ];
 
-    private static readonly HashSet<string> ElementExistenceMethods =
-    [
-        nameof(Enumerable.Contains),
-        nameof(Enumerable.Any),
-        nameof(List<int>.Exists)
-    ];
-
     private static readonly HashSet<string> AddOrRemoveMethods = [.. AddMethods, .. RemoveMethods];
 
     public static ProgramState LearnFrom(ProgramState state, IObjectCreationOperationWrapper operation)
@@ -156,19 +149,15 @@ public static ProgramState LearnFrom(ProgramState state, IInvocationOperationWra
         {
             return state.SetOperationConstraint(invocation, constraint);
         }
-
-        var instance = invocation.TargetMethod.IsExtensionMethod && !invocation.Arguments.IsEmpty
-            ? state.ResolveCaptureAndUnwrapConversion(invocation.Arguments[0].ToArgument().Value)
-            : invocation.Instance;
-        if (instance is { } && instance.Type.DerivesOrImplementsAny(CollectionTypes))
+        if (invocation.Instance is { } instance && instance.Type.DerivesOrImplementsAny(CollectionTypes))
         {
             var targetMethod = invocation.TargetMethod;
             var symbolValue = state[instance] ?? SymbolicValue.Empty;
             if (AddMethods.Contains(targetMethod.Name))
             {
                 return SetOperationAndSymbolValue(symbolValue.WithConstraint(CollectionConstraint.NotEmpty));
             }
-            else if (RemoveMethods.Contains(targetMethod.Name) || ElementExistenceMethods.Contains(targetMethod.Name))
+            else if (RemoveMethods.Contains(targetMethod.Name))
             {
                 return SetOperationAndSymbolValue(symbolValue.WithoutConstraint(CollectionConstraint.NotEmpty));
             }