Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Display list of unit tests #2166

Closed
wants to merge 8 commits into from
Closed

[WIP] Display list of unit tests #2166

wants to merge 8 commits into from

Conversation

Evangelink
Copy link
Contributor

Fix #886

@ghost ghost assigned Evangelink Dec 18, 2018
@ghost ghost added the Status: Needs Review label Dec 18, 2018
sonarcloud[bot]
sonarcloud bot reviewed Dec 18, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 7

See all issues in SonarCloud

sonarcloud[bot]
sonarcloud bot reviewed Dec 18, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 7

See all issues in SonarCloud

sonaranalyzer-dotnet/src/SonarAnalyzer.VisualBasic/Rules/Utilities/TestLocationAnalyzer.cs
ClassStatements.Add(node.ClassStatement);
}

public override void VisitStructureBlock(StructureBlockSyntax node)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. (csharpsquid:S1186)

See it in SonarCloud

sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/Utilities/TestLocationAnalyzer.cs
{
}

public override void VisitInterfaceDeclaration(InterfaceDeclarationSyntax node)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. (csharpsquid:S1186)

See it in SonarCloud

sonaranalyzer-dotnet/src/SonarAnalyzer.VisualBasic/Rules/Utilities/TestLocationAnalyzer.cs
{
}

public override void VisitEnumBlock(EnumBlockSyntax node)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. (csharpsquid:S1186)

See it in SonarCloud

sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/Utilities/TestLocationAnalyzer.cs
public override void VisitClassDeclaration(ClassDeclarationSyntax node)
{
ClassDeclarations.Add(node);
return;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Remove this redundant jump. (csharpsquid:S3626)

See it in SonarCloud

sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/Utilities/TestLocationAnalyzer.cs
return;
}

public override void VisitStructDeclaration(StructDeclarationSyntax node)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. (csharpsquid:S1186)

See it in SonarCloud

sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/Utilities/TestLocationAnalyzer.cs
{
}

public override void VisitEnumDeclaration(EnumDeclarationSyntax node)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. (csharpsquid:S1186)

See it in SonarCloud

sonaranalyzer-dotnet/src/SonarAnalyzer.VisualBasic/Rules/Utilities/TestLocationAnalyzer.cs
{
}

public override void VisitInterfaceBlock(InterfaceBlockSyntax node)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. (csharpsquid:S1186)

See it in SonarCloud

@Evangelink Evangelink changed the title Display list of unit tests [WIP] Display list of unit tests Dec 19, 2018
@pavel-mikula-sonarsource
Copy link
Contributor

Closing PR after closing original issue as Won't fix.
cc @andrei-epure-sonarsource

@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the ammo/list-uts branch March 12, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonarcloud SonarCloud sonarcloud left review comments

Assignees

@Evangelink Evangelink

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update plugin: display list of unit tests
3 participants
@Evangelink @pavel-mikula-sonarsource @valhristov