Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2077 FN: Add support for Mono.Data.Sqlite #7466

Merged
merged 8 commits into from
Jun 20, 2023
Merged

Fix S2077 FN: Add support for Mono.Data.Sqlite #7466

merged 8 commits into from
Jun 20, 2023

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Fixes #7261

Tim-Pohlmann
Tim-Pohlmann requested changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few overloads that still need to be covered.

...ers/tests/SonarAnalyzer.UnitTest/TestCases/Hotspots/ExecutingSqlQueries.Net46.MonoSqlLite.cs Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/Hotspots/ExecutingSqlQueries.Net46.MonoSqlLite.cs Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/Hotspots/ExecutingSqlQueries.Net46.MonoSqlLite.cs Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/Hotspots/ExecutingSqlQueries.Net46.MonoSqlLite.cs Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/Hotspots/ExecutingSqlQueries.Net46.MonoSqlLite.vb Outdated Show resolved Hide resolved
...ers/tests/SonarAnalyzer.UnitTest/TestCases/Hotspots/ExecutingSqlQueries.Net46.MonoSqlLite.vb Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Tim-Pohlmann
Tim-Pohlmann approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized you should also add compliant test cases for unformatted strings (literal or variable).
Everything else LGTM.

@martin-strecker-sonarsource
Copy link
Contributor Author

I just realized you should also add compliant test cases for unformatted strings (literal or variable).

There is https://github.com/SonarSource/sonar-dotnet/blob/2197ff3c45160f42ce0656e27a2b125a558c05a5/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Hotspots/ExecutingSqlQueries.Net46.cs which covers all these cases. The code paths are the same for Mono.SqlLite. I don't see the value to repeat all the cases again.

@martin-strecker-sonarsource martin-strecker-sonarsource merged commit 3475861 into master Jun 20, 2023
25 checks passed
@martin-strecker-sonarsource martin-strecker-sonarsource deleted the Martin/S2077_MonoSqlLite branch June 20, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Pohlmann Tim-Pohlmann Tim-Pohlmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S2077 FN: Add support for Mono.Data.Sqlite
2 participants
@martin-strecker-sonarsource @Tim-Pohlmann