New rule S6640: Allowing unsafe code is security-sensitive #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Pohlmann
force-pushed
the
Tim/S6640
branch
2 times, most recently
from
cb5e1a8
to
9ce1782
Compare
Tim-Pohlmann
commented
Jun 21, 2023
Tim-Pohlmann
requested review from
martin-strecker-sonarsource
and removed request for
martin-strecker-sonarsource
martin-strecker-sonarsource
requested changes
Jun 21, 2023
| public static class SyntaxTokenListExtensions | ||
| { | ||
| public static SyntaxToken? Find(this SyntaxTokenList tokenList, SyntaxKind kind) => | ||
| tokenList.IndexOf(kind) is var index && index != -1 |
There was a problem hiding this comment.
Alternative (I'm not sure whether it is better, so the change is optional):
Suggested change
| tokenList.IndexOf(kind) is var index && index != -1 | |
| tokenList.IndexOf(kind) is >= 0 and var index |
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/Hotspots/UnsafeCodeBlocks.cs
Show resolved
Hide resolved
analyzers/rspec/cs/S6640.json
Outdated
| "ruleSpecification": "RSPEC-6640", | ||
| "sqKey": "S6640", | ||
| "scope": "All", | ||
| "quickfix": "unknown" |
There was a problem hiding this comment.
Should be infeasible.
|
Kudos, SonarCloud Quality Gate passed! |
|
Kudos, SonarCloud Quality Gate passed!
|
martin-strecker-sonarsource
approved these changes
Jun 21, 2023
| "ruleSpecification": "RSPEC-6640", | ||
| "sqKey": "S6640", | ||
| "scope": "All", | ||
| "quickfix": "infeasible" |
There was a problem hiding this comment.
Your RSpec change was merged by me. You may want to run the update script again against RSpec master, just to make sure everything is as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7290