Improve S6640: Support type declarations #7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Pohlmann
commented
Jun 21, 2023
Comment on lines
+3
to
+28
| { | ||
| "id": "S6640", | ||
| "message": "Make sure that using "unsafe" is safe here.", | ||
| "location": { | ||
| "uri": "sources\Net5\Net5\FunctionPointers.cs", | ||
| "region": { | ||
| "startLine": 3, | ||
| "startColumn": 12, | ||
| "endLine": 3, | ||
| "endColumn": 18 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S6640", | ||
| "message": "Make sure that using "unsafe" is safe here.", | ||
| "location": { | ||
| "uri": "sources\Net5\Net5\S4000.cs", | ||
| "region": { | ||
| "startLine": 5, | ||
| "startColumn": 12, | ||
| "endLine": 5, | ||
| "endColumn": 18 | ||
| } | ||
| } | ||
| } |
Tim-Pohlmann
force-pushed
the
Tim/S6640
branch
2 times, most recently
from
ef2c836
to
d497ea9
Compare
Tim-Pohlmann
force-pushed
the
Tim/S6640_Types
branch
from
43128da
to
ee5d71d
Compare
Tim-Pohlmann
force-pushed
the
Tim/S6640_Types
branch
from
ee5d71d
to
47a185d
Compare
martin-strecker-sonarsource
requested changes
Jun 21, 2023
| context.RegisterNodeAction(c => | ||
| { | ||
| if (c.Node is BaseTypeDeclarationSyntax { Modifiers: var modifiers } | ||
| && modifiers.Find(SyntaxKind.UnsafeKeyword) is { } unsafeModifier) |
There was a problem hiding this comment.
Same here. Needs a re-base.
| { | ||
| Report(c, unsafeModifier); | ||
| } | ||
| }, SyntaxKind.ClassDeclaration, SyntaxKind.InterfaceDeclaration, SyntaxKind.StructDeclaration, SyntaxKindEx.RecordClassDeclaration); |
There was a problem hiding this comment.
RecordStruct seems to be missing.
Tim-Pohlmann
force-pushed
the
Tim/S6640_Types
branch
from
47a185d
to
2a19fa3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
martin-strecker-sonarsource
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #7290