Update .NET ITs results to contain the GitHub URL instead of relative path

[zsolt-kolbay-sonarsource]

Changes the uri from a relative local path to a clickable url pointing to Github with line numbers.
e.g.
from "sources\Automapper\src\AutoMapper\Execution\TypeMapPlanBuilder.cs"
to "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Automapper/src/AutoMapper/Execution/TypeMapPlanBuilder.cs#L401"

If an issue location spans multiple lines then that range is added to the end of the url: #L123-126

Review:

• the two Powershell scripts that were updated
• randomly check the json files and look for issues that are in a single line, as well as issues, where a location spans multiple lines, check whether the links are valid

Note: The order of the issues can change in a JSON file if one or more of the issue's locations is the Temporary-Folder, because these remain unchanged, while all the other locations are converted to urls.

[andrei-epure-sonarsource]

The GH UI is very slow, I am moving to PR-level comments rather than file comments.

index could be renamed to subPathStart (IMO more readable)

[andrei-epure-sonarsource]

regression-test.ps1 - line 337-338

# checks if one file path ends without another without their line number suffix (Program.cs#12 and Program.cs#34 -> true)
function EndsWithLineNumbersRemoved([string]$path1, [string]$path2) {

IMO the comment and name are cumbersome to understand.

Rather than saying what the function does from a mechanical POV (we can read the code for that...) - what is the functionality of this function?

Suggestion: IsSameFile

Also, I'd change the comment to something:

# checks if the file in `path2` is the same as the file in `path1` 
# example:
# path1: a/b/Program.cs#12
# path2: b/Program.cs#34
# result: true

[andrei-epure-sonarsource]

create-issue-reports.ps1 - Restore-UriDeclaration

In Restore-UriDeclaration, you removed $_.uri = $_.uri -replace "file:///" because now you're creating the URL.

So the # Remove the URI prefix comment seems to be out of date now.

[andrei-epure-sonarsource]

LGTM!

I verified (sampling) the 68699 modified URLs, out of which 329 are multi-line.

I believe it's good to have the multi-line URLs feature, as it gives a rough impression of the highlighting (even if it's not the fully accurate information, as it's missing columns).

[andrei-epure-sonarsource]

@zsolt-kolbay-sonarsource please give a heads-up to the whole squad when merging this, because everyone will need to rebase their PRs that have changed IT results

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information