Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java ITs: Remove "bulk_delete" orchestrator call #7556

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Java ITs: Remove "bulk_delete" orchestrator call #7556

merged 6 commits into from
Jul 12, 2023

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented Jul 7, 2023 •
edited
Loading

Part of #7557

  • CAYC: Remove some useless imports
  • CAYC: Changed some Before to BeforeClass annotations (running once per class instead of per file)
  • Remove bulk_delete call from orchestrator.reset() calls
  • vbnet+shared work out-of-the-box
  • C# needed projectKey de-collisioning for ExternalIssuesTest and IncrementalAnalysisTest
  • Added an overload method for csharp.Tests.analyzeProject to support different projectName and projectDir

@gregory-paidis-sonarsource gregory-paidis-sonarsource added Sprint: Java ITs Area: SQ Plugin Java plugin related issues. Type: Performance It takes too long. Type: Tooling Tools make us productive. and removed Type: Performance It takes too long. Area: SQ Plugin Java plugin related issues. Type: Tooling Tools make us productive. labels Jul 7, 2023
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1, I like your changes too much... I need more :D

its/src/test/java/com/sonar/it/csharp/AnalysisWarningsTest.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/AutoGeneratedTest.java Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/Tests.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/Tests.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/Tests.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/Tests.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/IncrementalAnalysisTest.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/vbnet/UnitTestResultsTest.java Outdated Show resolved Hide resolved
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done ™️

its/src/test/java/com/sonar/it/vbnet/Tests.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/MultiTargetAppTest.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/ProjectLevelDuplicationTest.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/csharp/RuleParameterCustomizationTest.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/it/shared/Tests.java Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 1d59f0d into feature/ITs Jul 12, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the greg/remove-bulk-delete branch July 12, 2023 13:48
pavel-mikula-sonarsource pushed a commit that referenced this pull request Jul 14, 2023
@gregory-paidis-sonarsource @pavel-mikula-sonarsource
Java ITs: Remove "bulk_delete" orchestrator call (#7556)
603fc10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-epure-sonarsource andrei-epure-sonarsource andrei-epure-sonarsource left review comments

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@gregory-paidis-sonarsource gregory-paidis-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregory-paidis-sonarsource @andrei-epure-sonarsource @pavel-mikula-sonarsource