Bump test dependencies #7873
Bump test dependencies #7873
Conversation
pavel-mikula-sonarsource
force-pushed
the
Pavel/BumpDependencies
branch
2 times, most recently
from
62081f6
to
f7405cb
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/BumpDependencies
branch
3 times, most recently
from
9d350f6
to
10992b0
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/BumpDependencies
branch
from
10992b0
to
1a90937
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned pavel-mikula-sonarsource
| @@ -391,7 +391,7 @@ public void Cfg_If_ElseIf() | |||
| secondCondition.SuccessorBlocks.Should().BeEquivalentTo(new[] { trueBlockY, exitBlock }); | |||
| secondCondition.BranchingNode.Kind().Should().Be(SyntaxKind.FalseLiteralExpression); | |||
|
|
|||
| exitBlock.PredecessorBlocks.Should().BeEquivalentTo(new[] { trueBlockX, trueBlockY, secondCondition }); | |||
| exitBlock.PredecessorBlocks.Should().BeEquivalentTo(new[] { trueBlockX, trueBlockY, secondCondition }, x => x.IgnoringCyclicReferences()); | |||
There was a problem hiding this comment.
New version of FluentAssertions has default limits that break the .Parent.Parent.Parent.Parent chain on the syntax
| @@ -917,8 +917,7 @@ public void ExplodedGraph_SwitchStatement_UnsupportedPatternKinds(string pattern | |||
| } | |||
| """; | |||
| var context = new ExplodedGraphContext(testInput); | |||
| var walk = () => context.WalkWithInstructions(2); | |||
| walk.Should().Throw<Exception>().WithMessage("Expected NumberOfExitBlockReached to be 1, but found 0 (difference of -1)."); | |||
| context.WalkWithExitBlocks(2, 0); | |||
There was a problem hiding this comment.
This started failing for wrong reason. This is the method that should have been used
| @@ -1,10 +1,10 @@ | |||
| using System; | |||
|
|
|||
| file class ClassNotExtended { } // Noncompliant {{File-scoped classes which are not derived in the current file should be marked as 'sealed'.}} | |||
| file class ClassNotExtended { } // Noncompliant {{File-scoped classes which are not derived in the current file should be marked as 'sealed'.}} | |||
There was a problem hiding this comment.
Some clean as you code whitespace. The file below is the actual change, because of invalid syntax in the new version
| @@ -172,7 +172,7 @@ stages: | |||
|
|
|||
| - powershell: | | |||
| cd analyzers | |||
| & dotnet test -f $(FrameworkMoniker) -c $(BuildConfiguration) -l trx /p:AltCover=true,AltCoverForce=true,AltCoverVisibleBranches=true,AltCoverAssemblyFilter='Moq|Humanizer|AltCover',AltCoverPathFilter='SonarAnalyzer\.CFG\\ShimLayer|SonarAnalyzer\.ShimLayer\.CodeGeneration',AltCoverAttributeFilter='ExcludeFromCodeCoverage',AltCoverReport=coverage/coverage.xml | |||
| & dotnet test -f $(FrameworkMoniker) -c $(BuildConfiguration) -l trx /p:AltCover=true,AltCoverForce=true,AltCoverVisibleBranches=true,AltCoverAssemblyFilter='Moq|Humanizer|AltCover|Microsoft.VisualStudio.TestPlatform.*|.*Test',AltCoverPathFilter='SonarAnalyzer\.CFG\\ShimLayer|SonarAnalyzer\.ShimLayer\.CodeGeneration',AltCoverAttributeFilter='ExcludeFromCodeCoverage',AltCoverReport=coverage/coverage.xml | |||
There was a problem hiding this comment.
(almost) related change to altcover bump. This will make coverage file smaller, because there's no reason to generate coverage data for TestPlatform assemblies and the test project themselves - the config is now the same as we did on security side
There was a problem hiding this comment.
LGTM!
Please fix the description of the PR as for example #7832 is not replaced by the PR.
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned csaba-sagi-sonarsource
Replaces #7856, #7872, #7613, #7571
Latest SDK fails due to altcover clash: microsoft/vstest#4106