SE: Add IInvocationOperationExtensions.Target tests
#9513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
added
Type: Cleanup
mary-georgiou-sonarsource
requested review from
sebastien-marichal and
Tim-Pohlmann
github-actions
bot
assigned sebastien-marichal and Tim-Pohlmann and unassigned mary-georgiou-sonarsource
Tim-Pohlmann
requested changes
Jul 11, 2024
analyzers/src/SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/HardcodedBytesRuleBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/HardcodedBytesRuleBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/HardcodedBytesRuleBase.cs
Outdated
Show resolved
Hide resolved
...src/SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/SecureRandomSeedsShouldNotBePredictable.cs
Outdated
Show resolved
Hide resolved
...src/SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/SecureRandomSeedsShouldNotBePredictable.cs
Outdated
Show resolved
Hide resolved
...zers/tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/IInvocationOperationExtensionsTest.cs
Outdated
Show resolved
Hide resolved
...zers/tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/IInvocationOperationExtensionsTest.cs
Outdated
Show resolved
Hide resolved
...zers/tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/IInvocationOperationExtensionsTest.cs
Outdated
Show resolved
Hide resolved
...zers/tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/IInvocationOperationExtensionsTest.cs
Outdated
Show resolved
Hide resolved
...zers/tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/IInvocationOperationExtensionsTest.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned Tim-Pohlmann and sebastien-marichal
mary-georgiou-sonarsource
force-pushed
the
mary/extensions
branch
4 times, most recently
from
5cc5a3d
to
6ea30bf
Compare
mary-georgiou-sonarsource
requested review from
Tim-Pohlmann
and removed request for
sebastien-marichal
| @@ -97,7 +97,7 @@ public override void ExecutionCompleted() | |||
| protected override ProgramState PreProcessSimple(SymbolicContext context) | |||
| { | |||
| if (context.Operation.Instance.AsInvocation() is { } invocation | |||
| && invocation.Instance is { } instance | |||
| && invocation.Target(context.State) is { } instance | |||
There was a problem hiding this comment.
I added a test with a fake extension method 😢
Tim-Pohlmann
approved these changes
Jul 11, 2024
...narAnalyzer.Test/TestCases/SymbolicExecution/Roslyn/EmptyCollectionsShouldNotBeEnumerated.cs
Show resolved
Hide resolved
...s/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/CollectionTracker.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
force-pushed
the
mary/extensions
branch
from
6f75804
to
1c95755
Compare
| @@ -720,6 +721,7 @@ public void Invocation_CollectionMethods_SetCollectionConstraint() | |||
| Verify("clear", ObjectConstraint.NotNull, CollectionConstraint.Empty); | |||
| Verify("add", ObjectConstraint.NotNull, CollectionConstraint.NotEmpty); | |||
| Verify("remove", ObjectConstraint.NotNull); | |||
| Verify("addExtension", ObjectConstraint.NotNull, CollectionConstraint.NotEmpty); | |||
There was a problem hiding this comment.
this was not adding notempty before that change in the collectionTracker that I missed adding a UT for.
|
|
mary-georgiou-sonarsource
changed the title
IInvocationOperationExtensions.GetInstance testsIInvocationOperationExtensions..Target tests
mary-georgiou-sonarsource
changed the title
IInvocationOperationExtensions..Target testsIInvocationOperationExtensions.Target tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.