Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README file #9611

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Update the README file #9611

merged 2 commits into from
Aug 7, 2024

Conversation

costin-zaharia-sonarsource
Copy link
Member

Fixes #9597

- Keep our changes and all logic in a dedicated directory `Sonar`, using partial classes, extension methods, and external handlers.
- Keep the namespace. Have different license headers.
- Inject ourselves to the StyleCop code with minimal changes that are annotated with // Sonar comment everywhere.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Inject ourselves to the StyleCop code with minimal changes that are annotated with // Sonar comment everywhere.
- Inject ourselves to the StyleCop code with minimal changes that are annotated with `// Sonar` comment everywhere.

analyzers/src/SonarAnalyzer.ShimLayer/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@CristianAmbrosini CristianAmbrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Aug 7, 2024

Copy link

sonarcloud bot commented Aug 7, 2024

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit 29e311c into master Aug 7, 2024
21 checks passed
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the costin/read-me branch August 7, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants