CR fixes

SonarSource · Oct 25, 2024 · 7bba13e · 7bba13e
1 parent ecd1521
commit 7bba13e
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/...rontend/src/main/java/org/sonar/python/semantic/v2/types/TrivialTypeInferenceVisitor.java b/...rontend/src/main/java/org/sonar/python/semantic/v2/types/TrivialTypeInferenceVisitor.java
@@ -471,10 +471,17 @@ public void visitName(Name name) {
       .map(Expression.class::cast)
       .map(Expression::typeV2)
       // TODO: classes (SONARPY-1829) and functions should be propagated like other types
-      .filter(t -> (t instanceof ClassType) || (t instanceof FunctionType) || (t instanceof ModuleType) || (t instanceof UnknownType.UnresolvedImportType))
+      .filter(TrivialTypeInferenceVisitor::shouldTypeBeEagerlyPropagated)
       .ifPresent(type -> setTypeToName(name, type));
   }
 
+  private static boolean shouldTypeBeEagerlyPropagated(PythonType t) {
+    return (t instanceof ClassType)
+           || (t instanceof FunctionType)
+           || (t instanceof ModuleType)
+           || (t instanceof UnknownType.UnresolvedImportType);
+  }
+
   private PythonType currentType() {
     return typeStack.peek();
   }