[NO-JIRA] Remove generic code smells

SonarSource · Mar 30, 2023 · b0076e1 · b0076e1
1 parent 6d724b5
commit b0076e1
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/server/sonar-auth-saml/src/main/java/org/sonar/auth/saml/SamlSettings.java b/server/sonar-auth-saml/src/main/java/org/sonar/auth/saml/SamlSettings.java
@@ -188,7 +188,8 @@ public static List<PropertyDefinition> definitions() {
         .build(),
       PropertyDefinition.builder(GROUP_NAME_ATTRIBUTE)
         .name("SAML group attribute")
-        .description("Attribute defining the user groups in SAML, used to synchronize group memberships. If you leave this field empty, group memberships are managed locally by SonarQube administrators.")
+        .description("Attribute defining the user groups in SAML, used to synchronize group memberships. If you leave this field empty, " +
+          "group memberships are managed locally by SonarQube administrators.")
         .category(CATEGORY)
         .subCategory(SUBCATEGORY)
         .index(10)

diff --git a/server/sonar-db-dao/src/main/java/org/sonar/db/issue/IssueTesting.java b/server/sonar-db-dao/src/main/java/org/sonar/db/issue/IssueTesting.java
@@ -24,8 +24,6 @@
 import org.sonar.api.issue.Issue;
 import org.sonar.api.resources.Qualifiers;
 import org.sonar.api.rule.Severity;
-import org.sonar.api.rules.RuleType;
-import org.sonar.api.utils.DateUtils;
 import org.sonar.core.util.UuidFactoryFast;
 import org.sonar.core.util.Uuids;
 import org.sonar.db.component.ComponentDto;

diff --git a/...ar-webserver-core/src/main/java/org/sonar/server/platform/monitoring/SettingsSection.java b/...ar-webserver-core/src/main/java/org/sonar/server/platform/monitoring/SettingsSection.java
@@ -91,7 +91,7 @@ public ProtobufSystemInfo.Section toProtobuf() {
     return protobuf.build();
   }
 
-  private void includeSetting(Builder protobuf, PropertyDefinitions definitions, Entry<String, String> prop) {
+  private static void includeSetting(Builder protobuf, PropertyDefinitions definitions, Entry<String, String> prop) {
     String key = prop.getKey();
     String value = obfuscateValue(definitions, key, prop.getValue());
     setAttribute(protobuf, key, value);

diff --git a/...onar-webserver-webapi/src/it/java/org/sonar/server/permission/ws/RemoveGroupActionIT.java b/...onar-webserver-webapi/src/it/java/org/sonar/server/permission/ws/RemoveGroupActionIT.java
@@ -153,8 +153,9 @@ public void fail_to_remove_last_admin_permission() {
     db.users().insertPermissionOnGroup(aGroup, GlobalPermission.PROVISION_PROJECTS);
     loginAsAdmin();
 
+    String administerPermission = GlobalPermission.ADMINISTER.getKey();
     assertThatThrownBy(() -> {
-      executeRequest(aGroup, GlobalPermission.ADMINISTER.getKey());
+      executeRequest(aGroup, administerPermission);
     })
       .isInstanceOf(BadRequestException.class)
       .hasMessage("Last group with permission 'admin'. Permission cannot be removed.");

diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/ce/queue/CeQueueCleaner.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/ce/queue/CeQueueCleaner.java
@@ -21,7 +21,6 @@
 
 import java.util.List;
 import org.sonar.api.Startable;
-import org.sonar.api.config.Configuration;
 import org.sonar.api.platform.ServerUpgradeStatus;
 import org.sonar.api.server.ServerSide;
 import org.sonar.api.utils.log.Logger;