Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Download links for album, playlist #383

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

muellerj
Copy link

Based on the work already done in #350.

@muellerj
Copy link
Author

TODO: Add the same functionality to playlists.

I wanted to implement this as well, but the songsManager currently seems to have no information about the membership of songs?

@muellerj
Copy link
Author

Update: I wrote a second patch which passes the required information along with each song and thus allows downloads of playlists as well. The /sync-endpoint thereby becomes slightly heavier, but overall the change is small.

Please review and let me know what you think.

@muellerj muellerj changed the title Add Download link for album Add Download links for album, playlist Feb 22, 2020
@muellerj
Copy link
Author

The settings seem to work consistently on Desktop (Chrome, Firefox, Safari) but I’ve not had reproducible results on iOS (some downloads seem to get skipped). Help is appreciated.

The obvious conceptual alternative is to create a zip file server-side and download that, but that’s a lot more involved in terms of code changes.

@amitjethani
Copy link

Would love to see this get merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants