Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修复了在启动agent服务检测环境时，如果项目路径或者相关依赖路径名称存在空格，则会报错的问题 #465

Merged
merged 1 commit into from
Sep 14, 2024
Merged

fix: 修复了在启动agent服务检测环境时，如果项目路径或者相关依赖路径名称存在空格，则会报错的问题 #465

merged 1 commit into from
Sep 14, 2024

Conversation

Coder-Huangzejia
Copy link
Contributor

@Coder-Huangzejia Coder-Huangzejia commented Sep 12, 2024 •
edited
Loading

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并，Sonic组织都非常感谢您的贡献。

Checklist

  • The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • I have considered and confirmed that this submission is valuable to others. | 我已经考虑过，并确认这份呈件对其他人很有价值。
  • I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

@prlabeler prlabeler bot added the fix label Sep 12, 2024
@Coder-Huangzejia Coder-Huangzejia marked this pull request as draft September 12, 2024 15:09
@Coder-Huangzejia Coder-Huangzejia marked this pull request as ready for review September 12, 2024 15:09
@Coder-Huangzejia Coder-Huangzejia changed the title fix: 修复了启动agent服务检测环境时，如果项目路径或者相关依赖路径名称存在空格报错的问题 fix: 修复了在启动agent服务检测环境时，如果项目路径或者相关依赖路径名称存在空格，则会报错的问题 Sep 12, 2024
SkMoran
SkMoran approved these changes Sep 12, 2024
View reviewed changes
Copy link

@SkMoran SkMoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem

ZhouYixun
ZhouYixun approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mg

@YeungHoiChiu
Copy link
Contributor

test pass

@ZhouYixun ZhouYixun merged commit 02a5667 into SonicCloudOrg:main Sep 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhouYixun ZhouYixun ZhouYixun approved these changes

@SkMoran SkMoran SkMoran approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Coder-Huangzejia @YeungHoiChiu @ZhouYixun @SkMoran