Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keychron K14 bring up #173

Merged
merged 5 commits into from
Dec 21, 2021
Merged

Keychron K14 bring up #173

merged 5 commits into from
Dec 21, 2021

Conversation

Jpe230
Copy link
Collaborator

@Jpe230 Jpe230 commented Dec 15, 2021

Add initial support for the newly released Keychron K14 RGB

Description

Added a default keymap that mimics the original firmware, all features seem to work (except bluetooth) and the keyboard is very stable with QMK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

dexter93
dexter93 requested changes Dec 21, 2021
View reviewed changes
Copy link

@dexter93 dexter93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, went through the PR. Nice job on the bringup. Please address the comments and cleanup any temporary commented code so we can merge this in

keyboards/keychron/k14/halconf.h Outdated Show resolved Hide resolved
keyboards/keychron/k14/config.h Outdated Show resolved Hide resolved
keyboards/keychron/k14/config_led.h Outdated Show resolved Hide resolved
keyboards/keychron/k14/bootloader_defs.h Outdated Show resolved Hide resolved
keyboards/keychron/k14/config.h Outdated Show resolved Hide resolved
keyboards/keychron/k14/config.h Outdated Show resolved Hide resolved
@dexter93 dexter93 merged commit 03c781d into SonixQMK:sn32 Dec 21, 2021
@Jpe230 Jpe230 deleted the keychron_k14 branch February 13, 2022 03:24
BestPig pushed a commit to BestPig/qmk_firmware that referenced this pull request Nov 18, 2023
@lokher
Merge pull request SonixQMK#173 from chigerpavel/Q1_PRO_typo_fix
eca6fea 
Fix typo in command examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter93 dexter93 dexter93 requested changes

Assignees
No one assigned
Labels
keyboard keymap python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jpe230 @dexter93