Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keychron C1] Migrate folder structure #227

Draft
wants to merge 47 commits into
base: sn32_master
Choose a base branch
from
Draft

[Keychron C1] Migrate folder structure #227

wants to merge 47 commits into from

Conversation

vjdato21
Copy link

@vjdato21 vjdato21 commented Feb 7, 2022 •
edited
Loading

Adopt new folder structure for Keychron C1.

Progress:

  • Plain = Complete. (needs testing though)
  • White = Complete. (needs testing though)
  • RGB = Complete.

Description

  • Address [Staging] Keychron K* breaking CI status #223
  • Codes that can be used across all variants are now using one file.
  • Updates to keymap and layout for all variants in order to address some issues and inconsistencies.
  • Now uses names for layers instead of numbers.
  • Changed Finder to Launchpad. (also uses a Mac virtual keycode)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

vjdato21 and others added 3 commits February 7, 2022 12:50
@vjdato21 @dexter93
@IsaacDynamo @noldevin @edlf
[Keychron C1 Series] Initial step to restructure
0826e4f 
- Consolidated some files in RGB variant especially.
- Currently, Plain variant has only been restructured.

Will appreciate your review about my commits.

Co-Authored-By: dexter93 <[email protected]>
Co-Authored-By: IsaacDynamo <[email protected]>
Co-Authored-By: noldevin <[email protected]>
Co-Authored-By: edlf <[email protected]>
@vjdato21 @dexter93
@IsaacDynamo @noldevin @edlf
[Keychron C1 Series] C1 White Restructure
33a7ebc 
- Issue with `keymap.c` compilation. Need help with this @IsaacDynamo

Co-Authored-By: dexter93 <[email protected]>
Co-Authored-By: IsaacDynamo <[email protected]>
Co-Authored-By: noldevin <[email protected]>
Co-Authored-By: edlf <[email protected]>
@vjdato21 @dexter93
@IsaacDynamo @noldevin @edlf
[Keychron C1 Series] Restructure C1 RGB
c3d0f00 
Co-Authored-By: dexter93 <[email protected]>
Co-Authored-By: IsaacDynamo <[email protected]>
Co-Authored-By: noldevin <[email protected]>
Co-Authored-By: edlf <[email protected]>
@vjdato21
[Keychron C1 Series] Update
b217366 
- Remove old and backup files.
- Fixed C1 RGB layout.
- Changed formatting of C1 RGB's keymap.
@vjdato21
[Keychron C1 Series] Some fixes again
312e0c6 
- Fixed layout for white and plain variants.
- Issue about compiling C1 White's VIA keymap has been found. Currently trying to coordinate with other maintainer for a resolution.
- Reorganize and reformatted keymap files.
@vjdato21
[Keychron C1 Series] Reduce the amount of keymaps
84d2802
@vjdato21
[Keychron C1 Series] Update readme.md
2aadf8e 
- Update make command.
@vjdato21
[Keychron C1 Series] Update readme.md
b0564ac
@vjdato21
Copy link
Author

vjdato21 commented Feb 8, 2022

@edlf Need your help for fixing the mess I caused in C1 Plain. Thanks.

@vjdato21
Copy link
Author

vjdato21 commented Feb 8, 2022

@edlf Need your help for fixing the mess I caused in C1 Plain. Thanks.

Invited you as a collaborator in my forked repository. Feel free to directly make changes/commits. Thanks again.

vjdato21 and others added 15 commits February 8, 2022 11:29
@vjdato21
Update config.h
46709e8
@edlf
Minor cleanups for C1 plain
4fa75df
@vjdato21
[Keychron C1 Series] Reorganizing keymaps
8a0150f 
C1 Plain still broken BTW XD
PR ain't ready until C1 Plain gets fixed.
@vjdato21
Update readme.md
a9e431f
@vjdato21
Update config.h
b232cc1
@vjdato21
Update config.h
ad29736
@vjdato21
Update c1.c
cb8ff37
@vjdato21
Merge branch 'sn32_master' into c1-restructure
143cc2a
@vjdato21 @tbowmo @dexter93
[Keychron C1 Series] More agnostic keymap
bbc4546 
- Now use one default keymap for every variant.
- Defines are now used to tailor for any differentiating keys across the variants.

Thanks to @tbowmo and @dexter93 for this nice suggestion.

Co-Authored-By: Thomas Mørch <[email protected]>
Co-Authored-By: dexter93 <[email protected]>
@vjdato21
[Keychron C1 Series] Fix keymap
f4253f6 
- Removed typo.
lol mbmb
@vjdato21
[Keychron C1 Series] Better keycode names XD
46360a7
@vjdato21
Some Keychron C1 White...
abf033e 
- Yeah, fixed some but like, it's still broken XD
- Add an ability to cycle through LED modes. Useless for now though since there are no enabled RGB modes except the solid XD.
@vjdato21
[Keychron C1 White & Plain] Some fixes and new stuff yes
05ab03b 
- Included a header that should supposedly be there but my pepega head didn't notice.
- Fixed keycode for Windows Lock.
- Returned `rand.c` again. Welcome back xD
@vjdato21
Update white.c
5f7b9e1
@vjdato21
[Keychron C1 Series] Update readme.md
c875b37
@vjdato21 vjdato21 marked this pull request as ready for review February 10, 2022 08:11
vjdato21 and others added 12 commits February 11, 2022 19:43
@vjdato21
[Keychron C1 RGB] Fix VIA
6f7572a 
- RGB control using VIA should work now again.
@vjdato21
[Keychron C1 Series] Tweaks to keymap
c81d103 
- Change layer names but attribute numbers to them as well.
- Fixed some extra key.
@vjdato21
[Keychron C1 Series] Tweak keymap.c
b601392 
- Change Finder to Launchpad.
- Use some weird way of sending keystroke for Mac specific keys.
- DIP switch logic for moving to a layer has been moved to `keymap.c`
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
0bb2794
@vjdato21
[Keychron C1 Series] Update keymap.c
78bb5aa 
- Update comment.
@vjdato21
Update keymap.c
43eaf19
@vjdato21
[Keychron C1 Series] Disable WAIT_FOR_USB
d94bd9b
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
6184745
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
3f36522
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
8406cd4
@vjdato21
[Keychron C1] Removed Launchpad Virtual Keycode
41f8b42
@vjdato21
uhm yes
32a661c
@vjdato21 vjdato21 changed the title [Keychron C1 Series] Migrate folder structure [Keychron C1] Migrate folder structure Mar 15, 2022
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
f7e27c0
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
362174c
@vjdato21
[Keychron C1] Set debounce for all
8337973 
- Added debounce for all variants.
@vjdato21
Update config.h
c2b7b38
@vjdato21
[Keychron C1 RGB] Fixed an oversight
2594262 
- Removed debounce for RGB config as it is already defined in all the C1 variants.
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
da6c705
@vjdato21
[Keychron C1] Reduce debounce
86e6f32 
- Playing around with debounce (trying to go with the sweetest spot).
- Multiple commits involving debounce may appear in future commits. (sorry, I don't have the compiler with my laptop right now coz my SSD is in the brink of death)
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
bbb431f
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
9d394dd
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
16d68cf
@vjdato21
Merge branch 'SonixQMK:sn32_master' into c1-restructure
0769b19
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale label Jul 20, 2023
@vjdato21 vjdato21 marked this pull request as draft July 24, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keyboard keymap stale via
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vjdato21 @dexter93 @edlf