K6 ansi bt port #390
K6 ansi bt port #390
Conversation
| "typing_heatmap" : true | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
idk how this passes linting. Please format the file properly
| * │Ctrl│GUI │Alt │ Space │Ctl│Fn1│Fn2│ ← │ ↓ │ → │ | ||
| * └────┴────┴────┴────────────────────────┴───┴───┴───┴───┴───┴───┘ | ||
| */ | ||
| [WIN_BASE] = LAYOUT_ansi(KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, RGB_MOD, KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BACKSLASH, KC_HOME, KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT, KC_PGUP, KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT, KC_UP, KC_PGDN, KC_LCTL, KC_LGUI, KC_LALT, KC_SPC, KC_RCTL, MO(WIN_FN1), MO(FN2), KC_LEFT, KC_DOWN, KC_RGHT), |
There was a problem hiding this comment.
layout is actually LAYOUT_65_ansi. Please see https://github.com/SonixQMK/qmk_firmware/tree/sn32_develop/layouts/default/65_ansi
and format it to something more readable
| #define SN32_RGB_MATRIX_ROW_PINS {C6, C5, C4, C9, C8, C7, C12, C11, C10, B13, C14, C13, B14, B15, D3} | ||
| #define DIP_SWITCH_PINS {D5, D4} | ||
| #define DYNAMIC_KEYMAP_LAYER_COUNT 5 | ||
| #define VIA_QMK_RGBLIGHT_ENABLE |
There was a problem hiding this comment.
| #define VIA_QMK_RGBLIGHT_ENABLE |
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "name": "Keychron K6 ISO", | |||
There was a problem hiding this comment.
via jsons should live inside the via keymap dir, in keyboard_via.json
|
|
||
| #pragma once | ||
| #define SN32_RGB_MATRIX_ROW_PINS {C6, C5, C4, C9, C8, C7, C12, C11, C10, B13, C14, C13, B14, B15, D3} | ||
| #define DIP_SWITCH_PINS {D5, D4} |
There was a problem hiding this comment.
this can be data driven now. See 98530ca
| #pragma once | ||
| #define SN32_RGB_MATRIX_ROW_PINS {C6, C5, C4, C9, C8, C7, C12, C11, C10, B13, C14, C13, B14, B15, D3} | ||
| #define DIP_SWITCH_PINS {D5, D4} | ||
| #define DYNAMIC_KEYMAP_LAYER_COUNT 5 |
There was a problem hiding this comment.
dynamic keymaps should be configured in via level, not here
|
Thank you for your contribution! |
dexter93
force-pushed
the
sn32_develop
branch
from
b4661f4
to
a5ecb97
Compare
|
Thank you for your contribution! |
Description
A Keychron K6 ANSI port for new keyboard declaration config system
I've dropped ISO layout, since i don't have one and keymap.c somehow differs from ANSI one
Feel free to adopt and add it as well
That port was done with upcoming iton_bt branch in mind
There are also some simple code related to RGB matrix bluetooth indication
Until iton_bt didn't merged - bluetooth part is disabled in rules.mk
For now it just builds and just works as intended
Types of Changes
Issues Fixed or Closed by This PR
Checklist