BIGGEST rover commit 😭️ #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
logbasem
reviewed
Apr 17, 2024
|
to get dependencies with Rye, do [project]
name = "autonomous"
version = "0.1.0"
description = "Add your description here"
authors = [{ name = "Barrett", email = "[email protected]" }]
dependencies = ["opencv-python>=4.7", "flask>=2.3.2", "loguru>=0.7.2"]
readme = "README.md"
requires-python = ">= 3.10"
[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"
[tool.rye]
managed = true
dev-dependencies = ["mypy>=1.8.0", "ruff>=0.2.0"]
[tool.hatch.metadata]
allow-direct-references = true
[tool.hatch.build.targets.wheel]
packages = ["./"]
and |
These lines were errors. Those are from a much older version of `opencv-python` than we're targeting.
this needs to return a bool so our callers know what's going on :)
|
lmk if any of these go too far and i'll revert it tried to keep things minimal though :3 |
accidentally stuck that return before all those calculations. oopsie :)
...we removed the ARUCO tag YOLO like a year ago lol
otherwise, this can be an infinite loop (as accessing the camera can prevent the system from doing so to further initialize it)
we had an error that was like: ```python3 import Drive from Drive import Drive ``` For reasons like this, it's super important to follow the spec for langs that prefer runtime checks...
|
CI passes so officially, we've won |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.