Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[수정] fixed 제거 #71 #72

Merged
merged 4 commits into from
Sep 24, 2022
Merged

[수정] fixed 제거 #71 #72

merged 4 commits into from
Sep 24, 2022

Conversation

SeonHwan-Kim
Copy link
Collaborator

@SeonHwan-Kim SeonHwan-Kim commented Sep 24, 2022

개요

작업 전

작업 사항

  • nvigation의 fixed를 제거해주고 mainpage의 margin을 없애 해결하였다
  • 메뉴 버튼 클릭 시 mainpage 부분과 sidebar 부분이 겹치는 문제가 있어 z-index를 1로 설정하였다
  • --vh를 설정해주고 css에서 height를 calc(var(--vh) * 100) 을 해주었다
  • --vh는 하단 탭바를 제외한 높이를 구하여 저장한다

@netlify
Copy link

netlify bot commented Sep 24, 2022

Deploy Preview for reserve-terrace ready!

Name Link
🔨 Latest commit 1d13a26
🔍 Latest deploy log https://app.netlify.com/sites/reserve-terrace/deploys/632f3618c9a5520008865e53
😎 Deploy Preview https://deploy-preview-72--reserve-terrace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gomjellie
Copy link
Member

PR 내용에 변경 이전의 스크린샷과 변경 이후의 스크린샷이 들어가면 좋을거같네요

@SeonHwan-Kim
Copy link
Collaborator Author

PR 내용에 변경 이전의 스크린샷과 변경 이후의 스크린샷이 들어가면 좋을거같네요

넵!! 아직 오류가 해결이 안된 것 같아 오류 수정 마무리하고 다시 올리겠습니다!

@SeonHwan-Kim SeonHwan-Kim merged commit 7fbe577 into main Sep 24, 2022
@SeonHwan-Kim SeonHwan-Kim deleted the mainpage branch September 24, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants