-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning - Controllers cleaning #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaning - user controller cleaning
controller to separate fil
All the codes referred to swagger routes were moved from the company
PatrickOtero
changed the title
Cleaning - User controller cleaning
Cleaning - Controllers cleaning
Sep 7, 2023
Cleaning - Auth controller
Cleaning/report controller
Upload controller cleaning
fixing swagger decorators location
Fixed incorrect imports
wandersonDeve
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major change was the move of the swagger decorators in controller files to other separate files. Some secondary cleaning was made like some minor errors as incorrect status returned and the correction of incomplete and/or less efficient validation details. Two routes had their logic fixed, they are: getOneUser and deleteUser, because they were not working as it should, as they were only returning the logged user and not searching for a specific user through his id. Also the api was set temporarily to not reject unauthorized access attempts in order to allow the continuation of its development.