add perplexity prompter #327
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe pull request introduces support for the Perplexity AI language model provider in the existing AI infrastructure. A new file Changes
Sequence DiagramsequenceDiagram
participant Client
participant AIInfrastructure
participant PerplexityAPI
Client->>AIInfrastructure: Request AI Prompt
AIInfrastructure->>PerplexityAPI: Send Completion Request
PerplexityAPI-->>AIInfrastructure: Return AI Response
AIInfrastructure-->>Client: Deliver AI Response
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
internal/infrastructure/ai/perplexity.go (2)
19-21: Correct the typo for the timeout constant name.
It appears there is a typographical error: "DefautTimeout" should be "DefaultTimeout" for clarity and consistency.- DefautTimeout = 10 * time.Second + DefaultTimeout = 10 * time.Second
73-82: Consider making the API key field configurable for Perplexity.
Currently, it uses cfg.OpenAIKey. If this key is specific to Perplexity, rename it to reflect "PerplexityKey" in the config for improved clarity and maintainability. Otherwise, ensure that using cfg.OpenAIKey is intentional.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum,!**/*.sum
📒 Files selected for processing (2)
internal/infrastructure/ai/ai.go(1 hunks)internal/infrastructure/ai/perplexity.go(1 hunks)
🔇 Additional comments (2)
internal/infrastructure/ai/perplexity.go (1)
136-177: Revisit unsubscribing logic in streaming callback.
In lines 145, 151, and 166, the subscription is managed multiple times (subscribe once and unsubscribe twice). Make sure that unsubscribing more than once doesn't produce undefined behavior or race conditions.
internal/infrastructure/ai/ai.go (1)
24-26: Implement configuration checks for Perplexity initialization.
Ensure that all relevant Perplexity configuration fields (endpoint, key, model) are validated. Otherwise, the function may succeed with incorrect configuration.
| func (o *Perplexity) EmbeddingFunc() func(ctx context.Context, text string) ([]float32, error) { | ||
| panic("not implemented") | ||
| } |
There was a problem hiding this comment.
Avoid panic in placeholder method.
Returning an error or a stub might be more appropriate than panicking if embedding is not yet implemented. Panics can disrupt system stability.
-func (o *Perplexity) EmbeddingFunc() func(ctx context.Context, text string) ([]float32, error) {
- panic("not implemented")
+func (o *Perplexity) EmbeddingFunc() func(ctx context.Context, text string) ([]float32, error) {
+ return func(ctx context.Context, text string) ([]float32, error) {
+ return nil, fmt.Errorf("embedding not implemented yet")
+ }
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| func (o *Perplexity) EmbeddingFunc() func(ctx context.Context, text string) ([]float32, error) { | |
| panic("not implemented") | |
| } | |
| func (o *Perplexity) EmbeddingFunc() func(ctx context.Context, text string) ([]float32, error) { | |
| return func(ctx context.Context, text string) ([]float32, error) { | |
| return nil, fmt.Errorf("embedding not implemented yet") | |
| } | |
| } |
| func (s *Perplexity) Prompt(ctx context.Context, input string) (*Result, error) { | ||
| r := &CompletionResponse{} | ||
|
|
||
| reqBody := CompletionRequest{ | ||
| Messages: []Message{{Role: "user", Content: input}}, | ||
| Model: s.model, | ||
| } | ||
|
|
||
| requestBody, err := json.Marshal(reqBody) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to marshal request body: %w", err) | ||
| } | ||
|
|
||
| ctx, cancel := context.WithDeadline(ctx, time.Now().Add(s.httpTimeout)) | ||
| defer cancel() | ||
|
|
||
| req, err := http.NewRequestWithContext(ctx, "POST", s.endpoint, bytes.NewBuffer(requestBody)) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to create request: %w", err) | ||
| } | ||
|
|
||
| req.Header.Set("Authorization", "Bearer "+s.apiKey) | ||
| req.Header.Set("Content-Type", "application/json") | ||
|
|
||
| resp, err := s.httpClient.Do(req) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to send request: %w", err) | ||
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| if resp.StatusCode != http.StatusOK { | ||
| if resp.StatusCode == http.StatusUnauthorized { | ||
| return nil, fmt.Errorf("unauthorized: check your API key") | ||
| } | ||
| return nil, fmt.Errorf("unexpected status code: %d", resp.StatusCode) | ||
| } | ||
|
|
||
| body, err := io.ReadAll(resp.Body) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to read response body: %w", err) | ||
| } | ||
|
|
||
| err = json.Unmarshal(body, r) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to unmarshal response body: %w - body response=%s", err, string(body)) | ||
| } | ||
|
|
||
| return &Result{ | ||
| Answer: r.Choices[0].Message.Content, | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
Validate the presence of response choices to prevent out-of-bounds errors.
In rare error scenarios, r.Choices could be empty. We should check the length of r.Choices before accessing r.Choices[0].
return &Result{
- Answer: r.Choices[0].Message.Content,
+ Answer: func() string {
+ if len(r.Choices) > 0 {
+ return r.Choices[0].Message.Content
+ }
+ return ""
+ }(),
}, nil📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| func (s *Perplexity) Prompt(ctx context.Context, input string) (*Result, error) { | |
| r := &CompletionResponse{} | |
| reqBody := CompletionRequest{ | |
| Messages: []Message{{Role: "user", Content: input}}, | |
| Model: s.model, | |
| } | |
| requestBody, err := json.Marshal(reqBody) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to marshal request body: %w", err) | |
| } | |
| ctx, cancel := context.WithDeadline(ctx, time.Now().Add(s.httpTimeout)) | |
| defer cancel() | |
| req, err := http.NewRequestWithContext(ctx, "POST", s.endpoint, bytes.NewBuffer(requestBody)) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to create request: %w", err) | |
| } | |
| req.Header.Set("Authorization", "Bearer "+s.apiKey) | |
| req.Header.Set("Content-Type", "application/json") | |
| resp, err := s.httpClient.Do(req) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to send request: %w", err) | |
| } | |
| defer resp.Body.Close() | |
| if resp.StatusCode != http.StatusOK { | |
| if resp.StatusCode == http.StatusUnauthorized { | |
| return nil, fmt.Errorf("unauthorized: check your API key") | |
| } | |
| return nil, fmt.Errorf("unexpected status code: %d", resp.StatusCode) | |
| } | |
| body, err := io.ReadAll(resp.Body) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to read response body: %w", err) | |
| } | |
| err = json.Unmarshal(body, r) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to unmarshal response body: %w - body response=%s", err, string(body)) | |
| } | |
| return &Result{ | |
| Answer: r.Choices[0].Message.Content, | |
| }, nil | |
| } | |
| func (s *Perplexity) Prompt(ctx context.Context, input string) (*Result, error) { | |
| r := &CompletionResponse{} | |
| reqBody := CompletionRequest{ | |
| Messages: []Message{{Role: "user", Content: input}}, | |
| Model: s.model, | |
| } | |
| requestBody, err := json.Marshal(reqBody) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to marshal request body: %w", err) | |
| } | |
| ctx, cancel := context.WithDeadline(ctx, time.Now().Add(s.httpTimeout)) | |
| defer cancel() | |
| req, err := http.NewRequestWithContext(ctx, "POST", s.endpoint, bytes.NewBuffer(requestBody)) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to create request: %w", err) | |
| } | |
| req.Header.Set("Authorization", "Bearer "+s.apiKey) | |
| req.Header.Set("Content-Type", "application/json") | |
| resp, err := s.httpClient.Do(req) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to send request: %w", err) | |
| } | |
| defer resp.Body.Close() | |
| if resp.StatusCode != http.StatusOK { | |
| if resp.StatusCode == http.StatusUnauthorized { | |
| return nil, fmt.Errorf("unauthorized: check your API key") | |
| } | |
| return nil, fmt.Errorf("unexpected status code: %d", resp.StatusCode) | |
| } | |
| body, err := io.ReadAll(resp.Body) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to read response body: %w", err) | |
| } | |
| err = json.Unmarshal(body, r) | |
| if err != nil { | |
| return nil, fmt.Errorf("failed to unmarshal response body: %w - body response=%s", err, string(body)) | |
| } | |
| return &Result{ | |
| Answer: func() string { | |
| if len(r.Choices) > 0 { | |
| return r.Choices[0].Message.Content | |
| } | |
| return "" | |
| }(), | |
| }, nil | |
| } |
No description provided.