Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Central API in Ops #189

Merged
merged 3 commits into from
May 7, 2024
Merged

Add Central API in Ops #189

merged 3 commits into from
May 7, 2024

Conversation

bitkeks
Copy link
Member

@bitkeks bitkeks commented May 7, 2024

Signed-off-by: Dominik Pataky <[email protected]>
@bitkeks bitkeks requested a review from maxwolfs May 7, 2024 10:51
@bitkeks bitkeks self-assigned this May 7, 2024
Copy link
Member

@maxwolfs maxwolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Still blocked by SovereignCloudStack/central-api#7

The glob for the repo source says 'docs/*.md', so the script copies all
Markdown files under docs/ into the target directory, removing the
folders 'docs/' prefix.

{
  "repo": "SovereignCloudStack/central-api",
  "source": "docs/*.md",
  "target": "docs/04-operating-scs/components",
  "label": "central-api"
}

Signed-off-by: Dominik Pataky <[email protected]>
bitkeks added a commit to SovereignCloudStack/central-api that referenced this pull request May 7, 2024
The link from README.md to poc-setup.md broke a build for the docs,
SovereignCloudStack/docs#189 which used the
README.md content as a placeholder.

Looking at it, it might make sense to move poc-setup into docs/ anyway.

Signed-off-by: Dominik Pataky <[email protected]>
@bitkeks bitkeks marked this pull request as draft May 7, 2024 11:57
bitkeks added a commit to SovereignCloudStack/central-api that referenced this pull request May 7, 2024
The link from README.md to poc-setup.md broke a build for the docs,
SovereignCloudStack/docs#189 which used the
README.md content as a placeholder.

Looking at it, it might make sense to move poc-setup into docs/ anyway.

Signed-off-by: Dominik Pataky <[email protected]>
bitkeks added a commit to SovereignCloudStack/central-api that referenced this pull request May 7, 2024
* fix: Move poc-setup.md into docs/ and adapt link in README.md

The link from README.md to poc-setup.md broke a build for the docs,
SovereignCloudStack/docs#189 which used the
README.md content as a placeholder.

Looking at it, it might make sense to move poc-setup into docs/ anyway.

Signed-off-by: Dominik Pataky <[email protected]>

* Revert "fix: Move poc-setup.md into docs/ and adapt link in README.md"

This reverts commit 7b970a5.

Signed-off-by: Dominik Pataky <[email protected]>

* fix: add ./docs/ prefix to linked page in README

Signed-off-by: Dominik Pataky <[email protected]>

---------

Signed-off-by: Dominik Pataky <[email protected]>
bitkeks added a commit to SovereignCloudStack/central-api that referenced this pull request May 7, 2024
* fix: Move poc-setup.md into docs/ and adapt link in README.md

The link from README.md to poc-setup.md broke a build for the docs,
SovereignCloudStack/docs#189 which used the
README.md content as a placeholder.

Looking at it, it might make sense to move poc-setup into docs/ anyway.

Signed-off-by: Dominik Pataky <[email protected]>

* Revert "fix: Move poc-setup.md into docs/ and adapt link in README.md"

This reverts commit 7b970a5.

Signed-off-by: Dominik Pataky <[email protected]>

* fix: add ./docs/ prefix to linked page in README

Signed-off-by: Dominik Pataky <[email protected]>

* Move poc-setup.md into docs/

Signed-off-by: Dominik Pataky <[email protected]>

---------

Signed-off-by: Dominik Pataky <[email protected]>
@bitkeks bitkeks marked this pull request as ready for review May 7, 2024 14:47
@bitkeks
Copy link
Member Author

bitkeks commented May 7, 2024

Architectural overview has an overflow now, will be picked up by @maxwolfs

@bitkeks bitkeks merged commit 4811caa into main May 7, 2024
4 checks passed
@bitkeks bitkeks deleted the feat/bk/add-centralapi branch May 7, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants