-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Central API in Ops #189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Pataky <[email protected]>
maxwolfs
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Still blocked by SovereignCloudStack/central-api#7
The glob for the repo source says 'docs/*.md', so the script copies all Markdown files under docs/ into the target directory, removing the folders 'docs/' prefix. { "repo": "SovereignCloudStack/central-api", "source": "docs/*.md", "target": "docs/04-operating-scs/components", "label": "central-api" } Signed-off-by: Dominik Pataky <[email protected]>
bitkeks
added a commit
to SovereignCloudStack/central-api
that referenced
this pull request
May 7, 2024
The link from README.md to poc-setup.md broke a build for the docs, SovereignCloudStack/docs#189 which used the README.md content as a placeholder. Looking at it, it might make sense to move poc-setup into docs/ anyway. Signed-off-by: Dominik Pataky <[email protected]>
bitkeks
added a commit
to SovereignCloudStack/central-api
that referenced
this pull request
May 7, 2024
The link from README.md to poc-setup.md broke a build for the docs, SovereignCloudStack/docs#189 which used the README.md content as a placeholder. Looking at it, it might make sense to move poc-setup into docs/ anyway. Signed-off-by: Dominik Pataky <[email protected]>
bitkeks
added a commit
to SovereignCloudStack/central-api
that referenced
this pull request
May 7, 2024
* fix: Move poc-setup.md into docs/ and adapt link in README.md The link from README.md to poc-setup.md broke a build for the docs, SovereignCloudStack/docs#189 which used the README.md content as a placeholder. Looking at it, it might make sense to move poc-setup into docs/ anyway. Signed-off-by: Dominik Pataky <[email protected]> * Revert "fix: Move poc-setup.md into docs/ and adapt link in README.md" This reverts commit 7b970a5. Signed-off-by: Dominik Pataky <[email protected]> * fix: add ./docs/ prefix to linked page in README Signed-off-by: Dominik Pataky <[email protected]> --------- Signed-off-by: Dominik Pataky <[email protected]>
bitkeks
added a commit
to SovereignCloudStack/central-api
that referenced
this pull request
May 7, 2024
* fix: Move poc-setup.md into docs/ and adapt link in README.md The link from README.md to poc-setup.md broke a build for the docs, SovereignCloudStack/docs#189 which used the README.md content as a placeholder. Looking at it, it might make sense to move poc-setup into docs/ anyway. Signed-off-by: Dominik Pataky <[email protected]> * Revert "fix: Move poc-setup.md into docs/ and adapt link in README.md" This reverts commit 7b970a5. Signed-off-by: Dominik Pataky <[email protected]> * fix: add ./docs/ prefix to linked page in README Signed-off-by: Dominik Pataky <[email protected]> * Move poc-setup.md into docs/ Signed-off-by: Dominik Pataky <[email protected]> --------- Signed-off-by: Dominik Pataky <[email protected]>
Signed-off-by: Dominik Pataky <[email protected]>
Architectural overview has an overflow now, will be picked up by @maxwolfs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on SovereignCloudStack/central-api#7