-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADR for Rook #737
Add ADR for Rook #737
Conversation
1ee3448
to
77f2f05
Compare
|
||
#### Evaluation in the Light of SCS Community Plans and Preferences | ||
|
||
**Environment**: Cephadm is better suited for traditional or standalone environments. Conversely, Rook is tailored for Kubernetes. That being said, it's important to note that the current state of resource deployment and management on Kubernetes within the reference implementation is still in its early stages. This would make Rook one of the first components to utilise Kubernetes in OSISM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Environment**: Cephadm is better suited for traditional or standalone environments. Conversely, Rook is tailored for Kubernetes. That being said, it's important to note that the current state of resource deployment and management on Kubernetes within the reference implementation is still in its early stages. This would make Rook one of the first components to utilise Kubernetes in OSISM. | |
**Environment**: Cephadm is better suited for traditional or standalone environments. Conversely, Rook is tailored for Kubernetes. That being said, it's important to note that the current state of resource deployment and management on Kubernetes within the IaaS reference implementation is still in its early stages. This would make Rook one of the first components to utilise Kubernetes in OSISM. |
Furthermore Keycloak is already being deployed to the kubernetes, so I'm not sure wether the statement of the Rook being the first holds. Nevertheless, it is early stages, so that of course is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that one of the first components
states that Rook isn't the very fist component on Kubernetes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only couple of minor corrections.
Thanks @b1-lender - this reads well. Since there are quite references to OSISM and its future direction (re. kubernetes), I think, it is important that @berendt comments. |
Co-authored-by: Eike Waldt <[email protected]> Co-authored-by: Jan-Marten Brüggemann <[email protected]> Co-authored-by: Boekhorst <[email protected]> Signed-off-by: Axel Lender <[email protected]>
Signed-off-by: Axel Lender <[email protected]>
Signed-off-by: Axel Lender <[email protected]>
Signed-off-by: Axel Lender <[email protected]>
Why was this merged when the test failed so blatantly? |
I didn't pay enough attention because merging was possible. |
I already created a PR to fix this, because it is currently blocking a PR I'm working on: #767 |
This PR adds an ADR regarding Rook.
fixes: SovereignCloudStack/issues#515