Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for Rook #737

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Add ADR for Rook #737

merged 5 commits into from
Oct 1, 2024

Conversation

b1-lender
Copy link
Contributor

This PR adds an ADR regarding Rook.
fixes: SovereignCloudStack/issues#515

@b1-lender b1-lender force-pushed the feat515 branch 6 times, most recently from 1ee3448 to 77f2f05 Compare September 9, 2024 10:12
@fkr fkr requested review from fkr and berendt September 24, 2024 07:33
@fkr fkr marked this pull request as ready for review September 24, 2024 07:34

#### Evaluation in the Light of SCS Community Plans and Preferences

**Environment**: Cephadm is better suited for traditional or standalone environments. Conversely, Rook is tailored for Kubernetes. That being said, it's important to note that the current state of resource deployment and management on Kubernetes within the reference implementation is still in its early stages. This would make Rook one of the first components to utilise Kubernetes in OSISM.
Copy link
Member

@fkr fkr Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Environment**: Cephadm is better suited for traditional or standalone environments. Conversely, Rook is tailored for Kubernetes. That being said, it's important to note that the current state of resource deployment and management on Kubernetes within the reference implementation is still in its early stages. This would make Rook one of the first components to utilise Kubernetes in OSISM.
**Environment**: Cephadm is better suited for traditional or standalone environments. Conversely, Rook is tailored for Kubernetes. That being said, it's important to note that the current state of resource deployment and management on Kubernetes within the IaaS reference implementation is still in its early stages. This would make Rook one of the first components to utilise Kubernetes in OSISM.

Furthermore Keycloak is already being deployed to the kubernetes, so I'm not sure wether the statement of the Rook being the first holds. Nevertheless, it is early stages, so that of course is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that one of the first components states that Rook isn't the very fist component on Kubernetes.

Copy link
Member

@fkr fkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only couple of minor corrections.

@fkr
Copy link
Member

fkr commented Sep 25, 2024

Thanks @b1-lender - this reads well. Since there are quite references to OSISM and its future direction (re. kubernetes), I think, it is important that @berendt comments.
For the formal correctness, I think it makes sense that someone like @markus-hentsch or @mbuechse reviews it, they're good with that :)

b1-lender and others added 3 commits September 25, 2024 08:53
Co-authored-by: Eike Waldt <[email protected]>
Co-authored-by: Jan-Marten Brüggemann <[email protected]>
Co-authored-by: Boekhorst <[email protected]>
Signed-off-by: Axel Lender <[email protected]>
@b1-lender b1-lender merged commit d909e9f into main Oct 1, 2024
6 of 7 checks passed
@b1-lender b1-lender deleted the feat515 branch October 1, 2024 07:53
@mbuechse
Copy link
Contributor

mbuechse commented Oct 1, 2024

ERROR: duplicates found: scs-0118-v1-rook-decision.md, scs-0118-v1-taxonomy-of-failsafe-levels.md

Why was this merged when the test failed so blatantly?

@b1-lender
Copy link
Contributor Author

I didn't pay enough attention because merging was possible.
What would be the preferred way to resolve this error, simply a new PR with the fix?

@tonifinger
Copy link
Contributor

tonifinger commented Oct 1, 2024

I didn't pay enough attention because merging was possible. What would be the preferred way to resolve this error, simply a new PR with the fix?

I already created a PR to fix this, because it is currently blocking a PR I'm working on: #767
Could i ask you to review it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New deployment and day-2-ops tooling software defined storage (ceph) - ADR
5 participants