Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golang version in example Dockerfile #747

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix golang version in example Dockerfile #747

merged 2 commits into from
Sep 17, 2024

Conversation

michal-gubricky
Copy link
Contributor

While following the SCS Kaas Sonobuoy test suite and the K8s e2e test framework guide step by step, I encountered this error::

 > [build 7/7] RUN --mount=type=cache,target=/root/.cache/go-build     go test -c -o custom.test ./...:                                                                                  
0.447 # golang.org/x/net/http2                                                                                                                                                           
0.447 /go/pkg/mod/golang.org/x/[email protected]/http2/transport.go:1096:13: tc.NetConn undefined (type *tls.Conn has no field or method NetConn)
0.447 note: module requires Go 1.18

@anjastrunk
Copy link
Contributor

I'm not competent enough to review this PR. I added @cah-patrickthiem and @tonifinger instead.

@anjastrunk anjastrunk removed their request for review September 16, 2024 08:56
@tonifinger tonifinger removed the request for review from cah-patrickthiem September 17, 2024 12:35
tonifinger
tonifinger approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@tonifinger tonifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michal-gubricky michal-gubricky merged commit 90f3244 into main Sep 17, 2024
8 checks passed
@michal-gubricky michal-gubricky deleted the fix/example-dockerfile branch September 17, 2024 13:13
@tonifinger tonifinger mentioned this pull request Sep 18, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonifinger tonifinger tonifinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michal-gubricky @anjastrunk @tonifinger