Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add endpoints to render certificate scopes #756

Merged
merged 4 commits into from
Oct 9, 2024
Merged

add endpoints to render certificate scopes #756

merged 4 commits into from
Oct 9, 2024

Conversation

mbuechse
Copy link
Contributor

No description provided.

@mbuechse mbuechse linked an issue Sep 19, 2024 that may be closed by this pull request
Compliance monitor: add endpoints to render certificate scopes #711
Closed
@mbuechse
Copy link
Contributor Author

Screenshot from 2024-09-19 20-58-51

almost the same as https://docs.scs.community/standards/scs-compatible-iaas

only that the former shows more versions, and this is better fixed by changing https://github.com/SovereignCloudStack/standards/blob/main/Tests/scs-compatible-iaas.yaml (remove v3-orig from latest timeline entry)

@mbuechse
Copy link
Contributor Author

mbuechse commented Sep 19, 2024 •
edited
Loading

This can be reviewed, I mainly need to update README.md

edit done

@mbuechse mbuechse marked this pull request as ready for review September 20, 2024 11:26
cah-patrickthiem
cah-patrickthiem reviewed Oct 8, 2024
View reviewed changes
Copy link

@cah-patrickthiem cah-patrickthiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I still have some minor complaints or questions.

cah-patrickthiem
cah-patrickthiem approved these changes Oct 9, 2024
View reviewed changes
Copy link

@cah-patrickthiem cah-patrickthiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now.

@mbuechse mbuechse merged commit b968b28 into main Oct 9, 2024
9 checks passed
@mbuechse mbuechse deleted the issue/711 branch October 9, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cah-patrickthiem cah-patrickthiem cah-patrickthiem approved these changes

@martinmo martinmo Awaiting requested review from martinmo

@fraugabel fraugabel Awaiting requested review from fraugabel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compliance monitor: add endpoints to render certificate scopes
2 participants
@mbuechse @cah-patrickthiem