Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result file #818

Closed
wants to merge 1 commit into from
Closed

Conversation

michal-gubricky
Copy link
Contributor

This PR should fix gen_sonobuoy_result_file, when I run the SCS KaaS default storage class v2 test l got this error:

miso@PC-Miso:~/standards/Tests/kaas$ python3 k8s-default-storage-class/k8s-default-storage-class-check.py

Traceback (most recent call last):
  File "/home/ubuntu/standards/Tests/kaas/k8s-default-storage-class/k8s-default-storage-class-check.py", line 269, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/ubuntu/standards/Tests/kaas/k8s-default-storage-class/k8s-default-storage-class-check.py", line 263, in main
    gen_sonobuoy_result_file(return_code, return_message, __file__)
  File "/home/ubuntu/standards/Tests/kaas/k8s-default-storage-class/helper.py", line 73, in gen_sonobuoy_result_file
    with open(f"./{test_name}.result.yaml", "w") as file:
FileNotFoundError: [Errno 2] No such file or directory: './/home/ubuntu/standards/Tests/kaas/k8s-default-storage-class/k8s-default-storage-class-check.result.yaml'

Signed-off-by: michal.gubricky <[email protected]>
@michal-gubricky michal-gubricky changed the title Fix gen_sonobuoy_result_file Fix result file Nov 11, 2024
@tonifinger
Copy link
Contributor

LGTM!
However, currently there is a PR #745 that revises the k8s-default-storage-class-check.py script.
I would suggest comparing it to this one. I expect it additionally fixes the same error as this PR.

@michal-gubricky
Copy link
Contributor Author

LGTM! However, currently there is a PR #745 that revises the k8s-default-storage-class-check.py script. I would suggest comparing it to this one. I expect it additionally fixes the same error as this PR.

Thanks, I wasn’t aware of that PR. I will take a look at it and if it addresses the issue, I'll close this PR in favor of #745.

@michal-gubricky
Copy link
Contributor Author

Closing in favor of #745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants