Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/documentation #12

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Chore/documentation #12

merged 4 commits into from
Jun 26, 2024

Conversation

joshuai96
Copy link
Member

Signed-off-by: Joshua Irmer <[email protected]>
@joshuai96 joshuai96 requested a review from joshmue June 25, 2024 13:20
@joshuai96 joshuai96 marked this pull request as draft June 25, 2024 13:21
Signed-off-by: Joshua Irmer <[email protected]>
@joshuai96 joshuai96 marked this pull request as ready for review June 25, 2024 14:40
Copy link
Contributor

@joshmue joshmue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with two minor suggestions).

docs/overview.md Outdated Show resolved Hide resolved
docs/overview.md Outdated Show resolved Hide resolved
Co-authored-by: Joshua Mühlfort <[email protected]>
Signed-off-by: Joshua Irmer <[email protected]>
@joshuai96 joshuai96 merged commit c7c73e6 into main Jun 26, 2024
1 check passed
@joshuai96 joshuai96 deleted the chore/documentation branch June 26, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants