Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add blog rookify #1012

Merged
merged 42 commits into from
Oct 30, 2024
Merged

Feat/add blog rookify #1012

merged 42 commits into from
Oct 30, 2024

Conversation

fkr
Copy link
Member

@fkr fkr commented Sep 4, 2024

No description provided.

@boekhorstb1 boekhorstb1 force-pushed the feat/add-blog-rookify-rook branch 3 times, most recently from 461d85f to b1ed562 Compare September 4, 2024 14:14
@fkr fkr force-pushed the feat/add-blog-rookify-rook branch from b1ed562 to d4309b1 Compare September 5, 2024 05:13
fkr
fkr commented Sep 5, 2024
View reviewed changes
Copy link
Member Author

@fkr fkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boekhorstb1 Very cool articles.
Couple suggestions:

  1. Let's move these into two PRs: one for the rook posts, one for the rookify posts
  2. Update the dates (for example tomorrow and monday)
  3. Let's get someone else to give it a final review, but they do LGTM.

@boekhorstb1 boekhorstb1 changed the title Feat/add blog rookify rook Feat/add blog rookify Sep 25, 2024
@boekhorstb1 boekhorstb1 self-assigned this Sep 25, 2024
@boekhorstb1
Copy link
Contributor

ok @fkr I moved this into two prs. The rook pr is found here #1026

@boekhorstb1
Copy link
Contributor

@NotTheEvilOne I added you as reviewer, as Felix suggested to have one more approval :)

@boekhorstb1
Copy link
Contributor

ok we made some significant changes to rook and as we did not pull this PR yet, I will try to incorporate them now

@boekhorstb1
Copy link
Contributor

ok latest changes should now be included in both the english and german version.

If we like, we can also wait for the osism/scs docs of rookify to be published. We could then mention them in this post as well. See here.

NotTheEvilOne
NotTheEvilOne requested changes Oct 23, 2024
View reviewed changes
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/en/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/en/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/en/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
@boekhorstb1
Copy link
Contributor

Thanks @NotTheEvilOne :)

NotTheEvilOne
NotTheEvilOne reviewed Oct 24, 2024
View reviewed changes
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/en/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
@boekhorstb1
add personal information
b98d796 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
feat: add initial blog entries for german and english translations
66aa87a 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
feat: blog for ceph with rook
09a2df6 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
blog update on rookify: adding a section to use testbed for testing r…
f4363bf 
…ookify

Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
add info about using rookify with testbed
fff4889 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
add more information about tested and cloud-in-a-box, also add missin…
b8ac5f3 
…g links

Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
update: add explanation of rooks workflow
fe65bcf 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
blog: statemachine design update
4c4b7be 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
blog: update work flow description
56a898e 
Signed-off-by: Boekhorst <[email protected]>
boekhorstb1 and others added 19 commits October 24, 2024 11:32
@boekhorstb1
fix: avatar jpg name
8283318 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: update to bio
60dde47 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
blogs: update, members: path update
3fb257e 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: typos, naming, links
d86ed90 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1 @fkr
Update _i18n/de/_posts/blog/2024-08-27-rookify.md
c67b2ea 
Co-authored-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: boekhorstb1 <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1 @fkr
Update _i18n/de/_posts/blog/2024-08-26-ceph-rook.md
2040ce6 
Co-authored-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: boekhorstb1 <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1 @fkr
Update _i18n/de/_posts/blog/2024-08-27-rookify.md
80aacb3 
Co-authored-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: boekhorstb1 <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1 @fkr
Update _i18n/en/_posts/blog/2024-08-26-ceph-rook.md
220829c 
Co-authored-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: boekhorstb1 <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: remove ceph post for other pr
2b02b25 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: english version: change date of creation and adapt blog to have …
b4b1401 
…latest changes to rookify

Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: more consistency on using capital letters for names
a13f989 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: change date of german blog and adapt text to include newest changes
648311a 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: precomit changes
0e3f25e 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
feat: english version: use headers instead of numbers
c757650 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: german version: adapt changes according to english version
f690499 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: spelling mistakes in en and de versions
c652300 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: change of wording and spelling errors
9e9c700 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: add k8s_prerequisites_check to general worklfow section
f6dc20a 
Signed-off-by: Boekhorst <[email protected]>
@boekhorstb1
fix: spelling
0a1ce39 
Signed-off-by: Boekhorst <[email protected]>
NotTheEvilOne
NotTheEvilOne approved these changes Oct 24, 2024
View reviewed changes
Copy link

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside two small additional changes it looks good for me :)

_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
_i18n/de/_posts/blog/2024-10-08-rookify.md Outdated Show resolved Hide resolved
@boekhorstb1
Copy link
Contributor

@fkr I think you can merge :)

@garloff
Copy link
Member

garloff commented Oct 25, 2024

Somebody should hit the "Squash and merge" button, no?
Any reason for not doing so, @boekhorstb1, @NotTheEvilOne, @fkr?

@boekhorstb1 boekhorstb1 merged commit 6f9f861 into main Oct 30, 2024
6 checks passed
@boekhorstb1 boekhorstb1 deleted the feat/add-blog-rookify-rook branch October 30, 2024 08:58
@boekhorstb1
Copy link
Contributor

ok I merged it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boekhorstb1 boekhorstb1 boekhorstb1 left review comments

@NotTheEvilOne NotTheEvilOne NotTheEvilOne approved these changes

Assignees

@boekhorstb1 boekhorstb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fkr @boekhorstb1 @garloff @NotTheEvilOne