[SKRB-152] feat: 암호화를 통한 develop 환경 서브모듈로 부터 제거 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeon-z
approved these changes
Oct 25, 2023
choi5798
reviewed
Oct 25, 2023
Comment on lines
11
to
13
| @Configuration | ||
| @Profile("develop") | ||
| public class PropertiesConfig { |
| String password = ""; | ||
| String urlResult = encryptor.encrypt(url); | ||
| String usernameResult = encryptor.encrypt(username); | ||
| String passwordReesult = encryptor.encrypt(password); |
There was a problem hiding this comment.
변수명에 Reesult는 오타인가요? 아니면 다른 뜻이 있는건가요?
Comment on lines
+3
to
+5
| url: ENC(otDA9awhWaUEIpsnbNeFYbtGftRKQJGT0sJCi+wsST/vLIAY7qgtfWUJ5DboDjtm75FCMg9NpMIO51aQRFjS9cjjelWOUltFnMEd2c295NvXg8xVH7Xm3eoDuXuSjWRH) | ||
| username: ENC(zmfwreAfhObIQDyz369dXg==) | ||
| password: ENC(u5djZgMAhFCL4roMXqGn8j3oj6AEcxh0) |
There was a problem hiding this comment.
ENC로 감싸진 해시값은 실제 값을 위 entryptionTest를 통해서 암호화를 시킨 값이에요
비밀번호는 dm으로 보내 드릴게요
choi5798
approved these changes
Oct 25, 2023
juno-junho
force-pushed
the
feat/SKRB-152
branch
from
b4b86c3
to
c80bd5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💠 Jira 티켓 링크
🖥️ 작업 내용
✅ PR시 확인 사항
📢 리뷰어 전달 사항