[SKRB-159] feat: Club 생성 관련 세부 기능 구현, dto 구체화 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choi5798
force-pushed
the
feat/SKRB-159
branch
2 times, most recently
from
f0d3b56
to
6926730
Compare
choi5798
force-pushed
the
feat/SKRB-159
branch
from
31f87dd
to
7b22add
Compare
hyeon-z
approved these changes
Oct 26, 2023
Comment on lines
+28
to
+29
| Club createdClub = service.createClub(newClub); | ||
| Long id = createdClub.getId(); |
There was a problem hiding this comment.
return한 후 id만 사용할 것이라면 엔티티를 return하는 이유가 있을까요?
There was a problem hiding this comment.
한줄에 여러 점을 찍지 않는다는 디미터의 법칙을 준수하기 위해 엔티티 획득후 id 획득으로 코드를 분리하였습니다
choi5798
force-pushed
the
feat/SKRB-159
branch
from
7b22add
to
70098d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💠 Jira 티켓 링크
🖥️ 작업 내용
✅ PR시 확인 사항
📢 리뷰어 전달 사항