Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SKRB-165] feat: 일반 사용자가 행사 참여 신청 현황 확인 기능을 위한 DTO 생성 #17

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

juno-junho
Copy link
Member

@juno-junho juno-junho commented Oct 26, 2023

💠 Jira 티켓 링크

🖥️ 작업 내용

  • 노션 API 명세에 맞게 dto 생성했습니다
  • 노션 링크

✅ PR시 확인 사항

  • 테스트 코드 작성 - PR 단위가 커질것 같아 다음 PR에서 올릴게요
  • Linear History 여부

📢 리뷰어 전달 사항

  • Event 도메인 건들였어요 (@hyeon-z 확인 부탁)

Copy link
Collaborator

@hyeon-z hyeon-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

노션 명세 확인했는데 Response로 pageData를 넘겨주는 이유가 있을까요?

@juno-junho
Copy link
Member Author

노션 명세 확인했는데 Response로 pageData를 넘겨주는 이유가 있을까요?

@hyeon-z 네 10개 참여 행사 넘어가면 페이지 시켜 달라던데요..?
하 근데 만들면서도 든 생각이 참여한 행사가 10개가 넘어갈 일이 있을지..

Copy link
Collaborator

@hyeon-z hyeon-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@choi5798 choi5798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요~

import java.util.List;

@RestController
@RequestMapping("/api/users")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 api endpoint 에는 버전 명시가 안되어있어요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하.. 성원님 그래서 이 다음 PR 테스트에서 수정했습니다..
이것 때문에 한두시간 날아갔어요

@juno-junho juno-junho merged commit 686151d into develop Oct 27, 2023
1 check passed
@juno-junho juno-junho deleted the feat/SKRB-165 branch October 27, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants