Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SKRB-183] fix: jasypt 관련 PropertiesConfig 설정 변경 #18

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

hyeon-z
Copy link
Collaborator

@hyeon-z hyeon-z commented Oct 26, 2023

💠 Jira 티켓 링크

🖥️ 작업 내용

  • 암호화 관련 PoolSize 1로 설정
  • S3 관련 설정 때문에 암호화 관련 @Profile설정에 local환경 추가

✅ PR시 확인 사항

  • 테스트 코드 작성
  • Linear History 여부

📢 리뷰어 전달 사항

@hyeon-z hyeon-z added the bug Something isn't working label Oct 26, 2023
@hyeon-z hyeon-z self-assigned this Oct 26, 2023
Copy link
Member

@juno-junho juno-junho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@choi5798 choi5798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
poolSize 를 1로 설정하신 이유가 무엇인가요?

@hyeon-z
Copy link
Collaborator Author

hyeon-z commented Oct 26, 2023

setPoolSize를 하지 않았을 때 null로 설정되어있는데 사이트에서 설정한 기본 값이 1이라서 1로 설정하였습니다!

@choi5798
Copy link
Member

사이트라면 어디 사이트를 말씀하시는건가요?

@hyeon-z hyeon-z changed the title [SKRB-183] fix: Property Config 설정 변경 [SKRB-183] fix: jasypt 관련 PropertiesConfig 설정 변경 Oct 26, 2023
@hyeon-z
Copy link
Collaborator Author

hyeon-z commented Oct 26, 2023

해당 라이브러리 깃허브 링크 첨부합니다!

@hyeon-z hyeon-z merged commit 9eb157f into develop Oct 26, 2023
1 check passed
@hyeon-z hyeon-z deleted the feat/SKRB-183 branch October 26, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants