Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SKRB-163] feat: 특정 사용자 컨트롤러 테스트 #19

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

juno-junho
Copy link
Member

@juno-junho juno-junho commented Oct 26, 2023

💠 Jira 티켓 링크

🖥️ 작업 내용

  • 테스트 및 rest docs 설정

✅ PR시 확인 사항

  • 테스트 코드 작성
  • Linear History 여부

📢 리뷰어 전달 사항

  • @hyeon-z Event 엔티티 생성자에 테스트 위해서 id 추가했습니다

Copy link
Collaborator

@hyeon-z hyeon-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 26 to 32
Page<Event> eventPages = userService.findAllEventPages(userId, pageable);
System.out.println(eventPages);
List<EventResponse> eventResponses = eventPages.getContent()
.stream()
.map(EventResponse::from)
.toList();
System.out.println("eventResponses = " + eventResponses);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

출력 구문 삭제헤주세요!

Copy link
Member

@choi5798 choi5798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요 👍

Comment on lines 7 to 14
public static EventResponse from(Event event) {
return new EventResponse(
event.getId(),
event.getEventInfo().getTitle(),
event.getEventInfo().getLocation(),
event.getClubHost()
);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엔티티 객체의 getter 없이 entity to dto 변환할 수 있는 방법은 어떤 것이 있을까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

없다 생각해요 ㅋㅋ

@juno-junho juno-junho merged commit b307405 into develop Oct 27, 2023
1 check passed
@juno-junho juno-junho deleted the feat/SKRB-163 branch October 27, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants