Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SKRB-184] refactor: DTO 이름 변경 및 SpaceClubCustomDisplayNameGenerator 수정 #21

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

juno-junho
Copy link
Member

@juno-junho juno-junho commented Oct 27, 2023

💠 Jira 티켓 링크

🖥️ 작업 내용

  • EventPageResponse를 PageResponse로 이름 변경해서 global > dto > 아래로 재사용할 수 있게 분리 했습니다
  • SpaceClubCustomDisplayNameGenerator 수정했으니 테스트마다@DisplayNameGeneration(SpaceClubCustomDisplayNameGenerator.class) 붙혀 사용하시면 될것 같아요

✅ PR시 확인 사항

  • 테스트 코드 작성
  • Linear History 여부

📢 리뷰어 전달 사항

== 작업내용

Copy link
Collaborator

@hyeon-z hyeon-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍☺️

Copy link
Member

@choi5798 choi5798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juno-junho juno-junho merged commit eab8ffc into develop Oct 27, 2023
1 check passed
@juno-junho juno-junho deleted the feat/SKRB-184 branch October 27, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants