[SKRB-148] feat: 행사 생성 API 틀 구현 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juno-junho
approved these changes
Oct 24, 2023
|
|
||
| import com.spaceclub.event.domain.Event; | ||
|
|
||
| public record CreateEventRequest(Long id) { |
There was a problem hiding this comment.
api틀 만든 PR 후 명세 관련 작업 커밋할 예정입니다! (DTO, controller 테스트)
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class EventService { |
There was a problem hiding this comment.
서비스 인터페이스로 만들어 놓고 빠르게 api 명세 뽑아도 좋을것 같아요
There was a problem hiding this comment.
서비스를 mock으로 테스트할 예정이라 class로 만들었습니다!
|
PR 제목 컨벤션 한번 확인해 주세요 feat이 빠졌어요 |
choi5798
requested changes
Oct 25, 2023
| private final EventService eventService; | ||
|
|
||
| @PostMapping | ||
| public ResponseEntity<Void> saveEvent(@RequestBody CreateEventRequest request) { |
There was a problem hiding this comment.
저희 컨트롤러, 서비스에서 생성 관련 메소드는 create로 시작하기로 컨벤션 정했어요
There was a problem hiding this comment.
EventController내의 메서드명이라 Event를 때고 create로 변경했습니다.
chore: controller 메서드 명 create으로 변경
| import lombok.NoArgsConstructor; | ||
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| @Entity | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| //@NoArgsConstructor(access = AccessLevel.PROTECTED) |
There was a problem hiding this comment.
특별한 의미를 나타내지 않는 주석은 지워도 될 것 같아요
There was a problem hiding this comment.
API 틀을 만들기 위해 임시로 변경한 부분이라 주석처리 했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💠 Jira 티켓 링크
🖥️ 작업 내용
✅ PR시 확인 사항
📢 리뷰어 전달 사항
틀 구현을 위해 임시로 넣은 값
controller의LocationCreateEventRequest의 파라미터,toEntity메서드Event엔티티의 기본 생성자